Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS,Windows] Use static casts where possible #40334

Merged
merged 1 commit into from Mar 16, 2023

Conversation

cbracken
Copy link
Member

Fixes a few instances where we were using reinterpret_cast and reinterpret_pointer_cast but could have been using static_cast since the types being cast between are related types in the same hierarchy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Fixes a few instances where we were using reinterpret_cast and
reinterpret_pointer_cast but could have been using static_cast since the
types being cast between are related types in the same hierarchy.
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as long as the compiler agrees, right?

@cbracken
Copy link
Member Author

cbracken commented Mar 16, 2023

Yeah the various casts are compile-time features (except dynamic_cast which requires RTTI enabled). The real question is whether Windows is happy with this; the patch was written on a Mac, so I haven't tested on my Windows machine, but CI will tell us.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023
@auto-submit auto-submit bot merged commit c4eb291 into flutter:main Mar 16, 2023
34 checks passed
@cbracken cbracken deleted the fix-unnecessary-reinterpret branch March 16, 2023 01:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-macos platform-windows
Projects
None yet
2 participants