Rename setters for lifecycle state

[gspencergoog]

Description

This renames PlatformConfiguration::UpdateLifecycleState and RuntimeController::SetLifecycleState to PlatformConfiguration::UpdateInitialLifecycleState and RuntimeController::SetInitialLifecycleState, respectively, and some associated private functions.

This is because calling this function really only updates the initial state that the binding loads when it initializes, it doesn't continuously update the lifecycle state.

Tests

• No tests changed. This is a rename of the API, and currently doesn't appear to have any direct test dependencies.

One note: These appear to both be deprecated APIs. Perhaps it would be better to just remove them? The only thing is I'm not sure what the deprecation message means by "persistent isolate data", and what the replacement code would be.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[Hixie]

test-exempt: code refactor with no semantic change