Reland "Deprecate SingletonFlutterWindow and global window singleton (#39302)" #40511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#39302)" This reverts commit 62f2844.
gspencergoog
approved these changes
Mar 22, 2023
lib/ui/window.dart
Outdated
| /// Deprecated. Will be removed in a future version of Flutter. | ||
| /// | ||
| /// This global property is deprecated to prepare for Flutter's upcoming support | ||
| /// for multiple views and multiple windows. |
There was a problem hiding this comment.
Suggested change
| /// for multiple views and multiple windows. | |
| /// for multiple views and multiple windows. |
| /// platform-specific functionality. | ||
| /// * [PlatformDispatcher.views], for a list of all available views. | ||
| @Deprecated( | ||
| 'Look up the current FlutterView from the context via View.of(context) or consult the PlatformDispatcher directly instead. ' |
There was a problem hiding this comment.
If it's short enough, you could add the method to call on PlatformDispatcher.
There was a problem hiding this comment.
This is already super-long in the analyzer output. I'm gonna skip this :)
|
Downstream fixes have landed and rolled into the framework in (flutter/flutter#123215). Let's try this again! |
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straight reland without any changes. The fixes were done downstream in flutter/packages#3512 and flutter/flutter#123176.