Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web engine global tests. #40550

Merged
merged 8 commits into from Mar 23, 2023
Merged

Add web engine global tests. #40550

merged 8 commits into from Mar 23, 2023

Conversation

godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 23, 2023 •
edited

Global tests for the web engine builder.

Bug: flutter/flutter#121900

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

eyebrowsoffire
eyebrowsoffire approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thank you for doing this!

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 23, 2023
@auto-submit auto-submit bot merged commit 69bb649 into flutter:main Mar 23, 2023
42 checks passed
@godofredoc godofredoc deleted the add_web_engine_tests branch March 23, 2023 20:08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
69bb64937 Add web engine global tests. (flutter/engine#40550)
01c1cb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
2 participants
@godofredoc @eyebrowsoffire