New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding autosubmit configuration pointer file #40581
Conversation
|
||
# This file will be added to flutter's internal repository. | ||
# https://github.com/flutter/flutter/wiki/Autosubmit-bot | ||
config_path: 'autosubmit/flutter/autosubmit_main.yml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be autosubmit/engine/autosubmit_main.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. So how it works is that since we use the pointer file we can define a many-to-one relationship with the global files. Really the only one that was different right now is the one for master since flutter has not been moved to that default branch yet. So flutter -> autosubmit/flutter/autosubmit_main.yml and cocoon, engine, packages -> autosubmit/flutter/autosubmit_main.yml since they have the main branch in common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With that being said I could make it clear by putting the files in specific directories within flutter/.github if that is more readable and easier to follow? I am open to updating the whole config system after I can get the Dart team onboard. Then we can make this things super slick.
* Adding autosubmit config pointer file. * Add wiki page to the file
Adding the pointer file that points to the autosubmit configuration in flutter/.github.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.