Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding autosubmit configuration pointer file #40581

Merged
merged 4 commits into from Mar 24, 2023

Conversation

ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Mar 23, 2023

Adding the pointer file that points to the autosubmit configuration in flutter/.github.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ricardoamador ricardoamador changed the title Autosubmit Adding autosubmit configuration pointer file Mar 23, 2023

# This file will be added to flutter's internal repository.
# https://github.com/flutter/flutter/wiki/Autosubmit-bot
config_path: 'autosubmit/flutter/autosubmit_main.yml'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be autosubmit/engine/autosubmit_main.yml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. So how it works is that since we use the pointer file we can define a many-to-one relationship with the global files. Really the only one that was different right now is the one for master since flutter has not been moved to that default branch yet. So flutter -> autosubmit/flutter/autosubmit_main.yml and cocoon, engine, packages -> autosubmit/flutter/autosubmit_main.yml since they have the main branch in common.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that being said I could make it clear by putting the files in specific directories within flutter/.github if that is more readable and easier to follow? I am open to updating the whole config system after I can get the Dart team onboard. Then we can make this things super slick.

@ricardoamador ricardoamador merged commit 7b91f9d into flutter:main Mar 24, 2023
33 checks passed
@ricardoamador ricardoamador deleted the autosubmit branch March 24, 2023 15:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2023
eyebrowsoffire pushed a commit to eyebrowsoffire/engine that referenced this pull request Mar 27, 2023
* Adding autosubmit config pointer file.

* Add wiki page to the file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants