[macOS] Use the new update semantics embedder API #40584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This moves the Windows embedder to the new update semantics embedder API introduced by flutter#39807. This does not affect functionality hence why existing accessibility integration tests are unaffected. Part of: flutter/flutter#121176
loic-sharma
force-pushed
the
macos_update_semantics_2
branch
from
4b46e09
to
c135791
Compare
chunhtai
reviewed
Mar 24, 2023
shell/platform/darwin/macos/framework/Source/FlutterViewController.mm
Outdated
Show resolved
Hide resolved
cbracken
approved these changes
Mar 28, 2023
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2023
8 tasks
loic-sharma
added a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Mar 30, 2023
The old "update semantics" embedder API was deprecated as it could not guarantee ABI stability (see flutter/flutter#121176). It was replaced by a new embedder API (flutter#39807) and all affected embedders were migrated to this new embedder API (flutter#40072, flutter#40584). This change: 1. Removes plumbing that was used for the old "update semantics" embedder API 2. Moves all remaining tests to the types used by the new "update semantics" embedder API Completes: flutter/flutter#121176
loic-sharma
added a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Mar 30, 2023
The old "update semantics" embedder API was deprecated as it could not guarantee ABI stability (see flutter/flutter#121176). It was replaced by a new embedder API (flutter#39807) and all affected embedders were migrated to this new embedder API (flutter#40072, flutter#40584). This change: 1. Removes plumbing that was used for the old "update semantics" embedder API 2. Moves all remaining tests to the types used by the new "update semantics" embedder API Completes: flutter/flutter#121176
loic-sharma
added a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Mar 30, 2023
The old "update semantics" embedder API was deprecated as it could not guarantee ABI stability (see flutter/flutter#121176). It was replaced by a new embedder API (flutter#39807) and all affected embedders were migrated to this new embedder API (flutter#40072, flutter#40584). This change: 1. Removes plumbing that was used for the old "update semantics" embedder API 2. Moves all remaining tests to the types used by the new "update semantics" embedder API Completes: flutter/flutter#121176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the Windows embedder to the new update semantics embedder API introduced by #39807. This does not affect functionality hence why existing accessibility integration tests are unaffected.
Part of: flutter/flutter#121176
Background
FlutterSemanticsUpdate's ABI would break if we add new members toFlutterSemanticNodeorFlutterSemanticCustomAction. As a result, these old types were "frozen" and new members should be added to the new typesFlutterSemanticUpdate2,FlutterSemanticNode2, andFlutterSemanticCustomAction2that were introduced by #39807.For more information, see go/flutter-semantics-abi or the background section for this issue: flutter/flutter#121176
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.