Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial docs for the engine build definition. #40621

Merged
merged 1 commit into from Mar 30, 2023
Merged

Add initial docs for the engine build definition. #40621

merged 1 commit into from Mar 30, 2023

Conversation

godofredoc
Copy link
Contributor

This is an initial convertion to markdown from flutter.dev/go/engine-build-definition-language.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This is an initial convertion to markdown
from flutter.dev/go/engine-build-definition-language.
@chinmaygarde
Copy link
Member

LGTM. But this could also perhaps be in the wiki.

@godofredoc
Copy link
Contributor Author

LGTM. But this could also perhaps be in the wiki.

Thanks, I'll link this doc to the wiki. The main idea is to keep the docs closer to where they are being used to ensure they are getting updated when something on the definition language implementation changes.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023
@auto-submit auto-submit bot merged commit 5ee904e into flutter:main Mar 30, 2023
42 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2023
@godofredoc godofredoc deleted the add_build_def_docs branch March 31, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
2 participants