New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ICU dependency to updated build #40676
Conversation
@yaakovschectman Looks like you'll need to update licenses for checks to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. The patch command in the output likely won’t work as-is on Windows, but you can hand-edit the file to fix, and I suspect git apply
would work.
If so, feel free to send a patch to emit an updated command that works on all platforms.
9ca44e2
to
3326eb3
Compare
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
Updates the commit of ICU pulled from Chromium as a dependency. The new update includes a separate
flutter_desktop
build that includes collation data we can use for a11y purposes. This PR does not yet change the icudlt file used by desktop builds, it only updates the commit of ICU used. I intend to the above in a follow-up commit once we can be sure this can roll out.Part of flutter/flutter#117013
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.