Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "[web] Accepts assetBase through JS config. (#40615)" #40677

Merged
merged 6 commits into from Mar 28, 2023
Merged

Reland "[web] Accepts assetBase through JS config. (#40615)" #40677

merged 6 commits into from Mar 28, 2023

Conversation

ditman
Copy link
Member

@ditman ditman commented Mar 27, 2023

This PR relands #40615, by:

   info - test/engine/assets_test.dart:5:1 - This annotation must
     be attached to a library directive. Try attaching library
     annotations to library directives. - library_annotations

Fixes: flutter/flutter#122987

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman
Reland "[web] Accepts assetBase through JS config. (flutter#40615)"
43e723a 
This reverts commit 6cc2f9b, PR flutter#40670.
@ditman
Attach @teston to a library.
1eb5e19 
This solves an issue with the `library_annotations` lint that was
added to the repo:

```
   info - test/engine/assets_test.dart:5:1 - This annotation must
     be attached to a library directive. Try attaching library
     annotations to library directives. - library_annotations
```
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 27, 2023
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2023
@auto-submit auto-submit bot merged commit 0d8d295 into flutter:main Mar 28, 2023
34 checks passed
@ditman ditman deleted the reland-assetbase branch March 28, 2023 20:22
@ditman ditman mentioned this pull request Mar 28, 2023
Closed
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 28, 2023
@engine-flutter-autoroll
0d8d295c4 Reland "[web] Accepts assetBase through JS config. (flutter…
516e6a0 
…#40615)" (flutter/engine#40677)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebbar mdebbar mdebbar approved these changes

@yjbanov yjbanov Awaiting requested review from yjbanov

@eyebrowsoffire eyebrowsoffire Awaiting requested review from eyebrowsoffire

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
2 participants
@ditman @mdebbar