[iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. #40703

luckysmg · 2023-03-28T06:05:28Z

Fix:

Flutter TextField focus state is not correct when keyboard closed from platform side. flutter#123523

Before this patch:

see in linked issue.

After this patch:

iPhone	iPad

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the [CLA].
All existing and new tests are passing.

…rst responder.

cyanglaz

LGTM % nits

shell/platform/darwin/ios/framework/Source/FlutterEngineTest.mm

cyanglaz · 2023-03-28T16:50:44Z

Blocked by:
flutter/flutter#123523

Did you mean to link to a framework PR instead?

shell/platform/darwin/ios/framework/Source/FlutterEngineTest.mm

shell/platform/darwin/ios/framework/Source/FlutterTextInputDelegate.h

LongCatIsLooong · 2023-03-28T18:12:02Z

There's already this message: https://master-api.flutter.dev/flutter/services/TextInputClient/connectionClosed.html

LongCatIsLooong · 2023-03-28T18:18:59Z

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

@@ -1043,7 +1043,8 @@ - (BOOL)canBecomeFirstResponder {
 - (BOOL)resignFirstResponder {
  BOOL success = [super resignFirstResponder];
  if (success) {
-    [self.textInputDelegate flutterTextInputViewDidResignFirstResponder:self];
+    [self.textInputDelegate flutterTextInputViewDidResignFirstResponder:self


nit: Looks like this one will be called when either the Flutter framework or UIKit tells the input view to give up its first responder status. It seems redundant for the former since there's no need to inform the Flutter framework when it is the one that initiated the focus change.

Yes. When framework close the keyboard first, this will send a msg to framework but will be handled return by

https://github.com/flutter/flutter/blob/659ba386f6d045690f9783c79fe5d320fb7847a1/packages/flutter/lib/src/services/text_input.dart#L1788

And only when platform starts to unfocus, the _currentConnection!._client.connectionClosed(); will be called.

Currently, engine side doens't have a good simple way to know the original focus/unfocus signal is from framework or from platform, this maybe can be done by set some var like BOOL sendFromFramework to judge, but I think that will be overkill........(Maybe I missed something that can judge this)

So I think this cost can be acceptable? ^_^

Yeah that makes sense the old connection is already torn down by the framework so messages associated with the old client id will be thrown away.

luckysmg · 2023-03-29T00:10:56Z

There's already this message: https://master-api.flutter.dev/flutter/services/TextInputClient/connectionClosed.html

Oh.thx for reminding me that. I will try invoke that method to unfocus.

jmagman

This LGTM, would like @LongCatIsLooong to confirm concerns were addressed.

luckysmg · 2023-03-30T05:28:40Z

Thx everyone reviewing this. Applying label for merging O(∩_∩)O

…er to ensure framework focus state is correct. (flutter/engine#40703)

…rstResponder to ensure framework focus state is correct. (flutter/engine#40703) (flutter/flutter#123753)

…esponder to ensure framework focus state is correct. (#40703)" (#40777)" This reverts commit 75fabbe.

…er to ensure framework focus state is correct. (flutter/engine#40703) (flutter#123753) Roll Flutter Engine from 7dcbf0edf6b4 to bad50ddc9f3d (1 revision)

…rstResponder to ensure framework focus state is correct. (flutter/engine#40703) (flutter/flutter#123753)

luckysmg added 2 commits March 27, 2023 18:42

Send unfocus message to framework when FlutterTextInputView resign fi…

6cc3ba7

…rst responder.

Add Test

dbec70c

flutter-dashboard bot added the platform-ios label Mar 28, 2023

Merge branch 'main' into handle-unfocus

9472b6b

luckysmg mentioned this pull request Mar 28, 2023

Flutter TextField focus state is not correct when keyboard closed from platform side. flutter/flutter#123523

Closed

3 tasks

luckysmg requested review from hellohuanlin, cyanglaz and jmagman March 28, 2023 06:14

luckysmg self-assigned this Mar 28, 2023

luckysmg requested a review from LongCatIsLooong March 28, 2023 06:14

cyanglaz approved these changes Mar 28, 2023

View reviewed changes

shell/platform/darwin/ios/framework/Source/FlutterEngineTest.mm Outdated Show resolved Hide resolved

hellohuanlin approved these changes Mar 28, 2023

View reviewed changes

jmagman requested changes Mar 28, 2023

View reviewed changes

shell/platform/darwin/ios/framework/Source/FlutterEngineTest.mm Outdated Show resolved Hide resolved

shell/platform/darwin/ios/framework/Source/FlutterTextInputDelegate.h Outdated Show resolved Hide resolved

LongCatIsLooong reviewed Mar 28, 2023

View reviewed changes

luckysmg changed the title ~~[iOS] Send unfocus message to framework to ensure focus state is correct.~~ [iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. Mar 29, 2023

luckysmg added 3 commits March 29, 2023 11:10

Change channel

fcf40ed

++

0f877f4

++

1725876

luckysmg requested review from LongCatIsLooong and jmagman March 29, 2023 05:33

jmagman approved these changes Mar 29, 2023

View reviewed changes

LongCatIsLooong approved these changes Mar 30, 2023

View reviewed changes

luckysmg added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023

auto-submit bot merged commit bad50dd into flutter:main Mar 30, 2023
37 checks passed

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter Engine from 7dcbf0edf6b4 to bad50ddc9f3d (1 revision) flutter/flutter#123753

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2023

bad50ddc9 [iOS] Send connectionClosed message when resignFirstRespond…

4472117

…er to ensure framework focus state is correct. (flutter/engine#40703)

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to 8c5d223bab70 (49 revisions) flutter/packages#3594

Closed

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to 5f7117948072 (50 revisions) flutter/packages#3595

Closed

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to a28aae918eae (51 revisions) flutter/packages#3597

Closed

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to d940f60b4680 (70 revisions) flutter/packages#3605

Closed

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to f6c2b10e1a98 (71 revisions) flutter/packages#3606

Closed

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to f5415a42d342 (72 revisions) flutter/packages#3607

Closed

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to 63e30480cd51 (74 revisions) flutter/packages#3608

Closed

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to 9a344c2604ec (75 revisions) flutter/packages#3609

Closed

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to a8117bf18778 (76 revisions) flutter/packages#3610

Closed

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to 9d820aa35a22 (77 revisions) flutter/packages#3611

Closed

reidbaker mentioned this pull request Apr 1, 2023

Add Java-Gradle-AGP validation to flutter analyze flutter/flutter#123916

Merged

8 tasks

reidbaker mentioned this pull request Apr 5, 2023

Update getGradleVersion to ignore commented out lines flutter/flutter#124260

Merged

8 tasks

luckysmg added a commit that referenced this pull request Apr 10, 2023

Revert "Revert "[iOS] Send connectionClosed message when resignFirstR…

d02da0e

…esponder to ensure framework focus state is correct. (#40703)" (#40777)" This reverts commit 75fabbe.

luckysmg mentioned this pull request Apr 10, 2023

Reland [iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. #41022

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. #40703

[iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. #40703

luckysmg commented Mar 28, 2023 •

edited

cyanglaz left a comment

cyanglaz commented Mar 28, 2023 •

edited

LongCatIsLooong commented Mar 28, 2023

LongCatIsLooong Mar 28, 2023

luckysmg Mar 29, 2023 •

edited

LongCatIsLooong Mar 30, 2023

luckysmg commented Mar 29, 2023 •

edited

jmagman left a comment

luckysmg commented Mar 30, 2023

[iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. #40703

[iOS] Send connectionClosed message when resignFirstResponder to ensure framework focus state is correct. #40703

Conversation

luckysmg commented Mar 28, 2023 • edited

Before this patch:

After this patch:

Pre-launch Checklist

cyanglaz left a comment

Choose a reason for hiding this comment

cyanglaz commented Mar 28, 2023 • edited

LongCatIsLooong commented Mar 28, 2023

LongCatIsLooong Mar 28, 2023

Choose a reason for hiding this comment

luckysmg Mar 29, 2023 • edited

Choose a reason for hiding this comment

LongCatIsLooong Mar 30, 2023

Choose a reason for hiding this comment

luckysmg commented Mar 29, 2023 • edited

jmagman left a comment

Choose a reason for hiding this comment

luckysmg commented Mar 30, 2023

luckysmg commented Mar 28, 2023 •

edited

cyanglaz commented Mar 28, 2023 •

edited

luckysmg Mar 29, 2023 •

edited

luckysmg commented Mar 29, 2023 •

edited