Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable LTO and roll buildroot to enable sINLINING_LIMIT #40808

Merged
merged 2 commits into from Mar 31, 2023
Merged

Re-enable LTO and roll buildroot to enable sINLINING_LIMIT #40808

merged 2 commits into from Mar 31, 2023

Conversation

eyebrowsoffire
Copy link
Contributor

sINLINING_LIMIT seems to keep the binary size down even when LTO is enabled.

@eyebrowsoffire eyebrowsoffire marked this pull request as ready for review March 30, 2023 23:04
harryterkelsen
harryterkelsen approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #40808 at sha c6978d6

@auto-submit auto-submit bot merged commit 013e936 into main Mar 31, 2023
41 checks passed
@auto-submit auto-submit bot deleted the reenable_lto branch March 31, 2023 04:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
013e936fe Re-enable LTO and roll buildroot to enable sINLINING_LIMIT (
d3f2de7 
flutter/engine#40808)
harryterkelsen pushed a commit that referenced this pull request Mar 31, 2023
Revert "Re-enable LTO and roll buildroot to enable sINLINING_LIMIT (#…
795a2b2 
…40808)"

This reverts commit 013e936.
@harryterkelsen harryterkelsen mentioned this pull request Mar 31, 2023
Merged
harryterkelsen pushed a commit that referenced this pull request Mar 31, 2023
Revert "Re-enable LTO and roll buildroot to enable sINLINING_LIMIT" (…
69f1fa2 
…#40822)

Reverts #40808

Regresses benchmarks:
https://flutter-flutter-perf.skia.org/e/?numCommits=100&queries=test%3Dweb_benchmarks_canvaskit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App will affect goldens
Projects
None yet
Milestone
No milestone
2 participants
@eyebrowsoffire @harryterkelsen