New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Remove FlutterApplication class #40939
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
The need for the FlutterApplication NSApplication subclass was eliminated in 8679b67. The relevant app termination logic was moved into FlutterAppDelegate in that patch. Removing FlutterApplication needs to be done in three stages: 1. Migrate logic to FlutterAppDelegate (done in above patch) 2. Update Flutter tool template. Update migrator to migrate all apps using FlutterApplication back to NSApplication. This is done in flutter/flutter#124173. 3. Eliminate FlutterApplication.h header since all references to it have now been removed. Issue: flutter/flutter#30735
b4e1dfb
to
158598a
Compare
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The need for the FlutterApplication NSApplication subclass was eliminated in 8679b67. The relevant app termination logic was moved into FlutterAppDelegate in that patch. Removing FlutterApplication needs to be done in three stages:
No tests since, as described above, this is the removal of unused (as of step 2 above) code.
Issue: flutter/flutter#30735
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.