New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Fix trivial type issue. #40956
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@eyebrowsoffire ptal, just a trivial fix to the type here. |
The changed line here causes problems with https://dart-review.googlesource.com/c/sdk/+/292881, right? Assuming the CL is correct, how did this line work on other web backends before? Shouldn't this line cause runtime type errors in other backends that implement runtime type tests correctly? |
I think what might be happening here is that |
test-exempt: current code doesn't pass tests |
…125183) flutter/engine@d726345...2db85cb 2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from suSuT9F8zuP-pBg-E... to OcPCdaE17MAihaCrD... (flutter/engine#41352) 2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from fe8bb0565a30 to 88a3b66b50d6 (2 revisions) (flutter/engine#41349) 2023-04-19 bdero@google.com Add missing header guards (flutter/engine#41322) 2023-04-19 joshualitt@google.com [web] Fix trivial type issue. (flutter/engine#40956) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from suSuT9F8zuP- to OcPCdaE17MAi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
No description provided.