Adds AndroidSurfaceGLImpeller unit tests #40979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
changed the title
8 tasks
gaaclarke
force-pushed
the
andorid_surface_gl_impeller_unitests
branch
from
cf3333e
to
4cd31f0
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
chinmaygarde
approved these changes
Apr 10, 2023
chinmaygarde
changed the title
chinmaygarde
force-pushed
the
andorid_surface_gl_impeller_unitests
branch
from
0af6d8f
to
b0aeb4a
Compare
chinmaygarde
added
the
autosubmit
|
Aaron is going be OOO for a bit. Rebasing and landing so we don't lose track. |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 40979, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
gaaclarke
force-pushed
the
andorid_surface_gl_impeller_unitests
branch
from
b0aeb4a
to
2534c43
Compare
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 17, 2023
…124987) flutter/engine@30e1c43...b2d0738 2023-04-17 30870216+gaaclarke@users.noreply.github.com Adds AndroidSurfaceGLImpeller unit tests (flutter/engine#40979) 2023-04-17 yjbanov@google.com [web:canvaskit] migrate Paint API to UniqueRef (flutter/engine#41230) 2023-04-17 kjlubick@users.noreply.github.com Migrate uses of deprecated SkImage->encodeToData (flutter/engine#41204) 2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 962800967591 to d9e216e62223 (1 revision) (flutter/engine#41270) 2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from xPacy_rLieLS05d_g... to K1LGtKXyxRlW3Q9O1... (flutter/engine#41271) 2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 82665485077b to 962800967591 (1 revision) (flutter/engine#41267) 2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 5c4d2a518736 to 82665485077b (2 revisions) (flutter/engine#41266) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from xPacy_rLieLS to K1LGtKXyxRlW If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #40944
issue flutter/flutter#105323
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.