Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP][web] Make 'Noto Color Emoji' opt-in (#40990) #40991

Conversation

CaseyHillers
Copy link
Contributor

[web] Make 'Noto Color Emoji' opt-in

b/277330347 - This incurred a large 24 MB size increase for web projects that is blocking customer releases.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

[web] Make 'Noto Color Emoji' opt-in
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 7, 2023
@XilaiZhang
Copy link
Contributor

Umm I think flutter-3.10-candidate.1 is tied to the current roll at commit e749db6

@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented Apr 7, 2023

Umm I think flutter-3.10-candidate.1 is tied to the current roll at commit e749db6

Exactly :-)

Your roll will land, and I'll CP in afterwards. Since this is going to take several hours to run through LUCI, I'm starting now.

@flutter flutter deleted a comment from XilaiZhang Apr 7, 2023
@CaseyHillers CaseyHillers merged commit 311ed5a into flutter:flutter-3.10-candidate.1 Apr 7, 2023
35 checks passed
@CaseyHillers CaseyHillers deleted the flutter-3.10-candidate.1 branch April 7, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine
Projects
None yet
4 participants