[web] Expose PlatformLocation and HashUrlStrategy through ui_web #41163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
eyebrowsoffire
approved these changes
May 9, 2023
yjbanov
reviewed
May 9, 2023
lib/web_ui/lib/ui_web/src/ui_web/navigation/platform_location.dart
Outdated
Show resolved
Hide resolved
| abstract class UrlStrategy { | ||
| /// Abstract const constructor. This constructor enables subclasses to provide | ||
| /// const constructors so that they can be used in const expressions. | ||
| const UrlStrategy(); |
There was a problem hiding this comment.
Same here. All methods are abstract, which tells me this class can be implemented. So we don't need a constructor. The implementation can still be const.
There was a problem hiding this comment.
Thanks for the suggestion! I changed PlatformLocation to be an abstract interface (TIL about interfaces in Dart!).
That said, I can't make UrlStrategy an interface yet because it's being extended in flutter_web_plugins. I'll need to change that to implements first then come back and make UrlStrategy an interface. I'll do it in a follow up PR.
mdebbar
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
mdebbar
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41163, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 11, 2023
…126486) flutter/engine@ef771f9...a0925f1 2023-05-10 mdebbar@google.com [web] Expose PlatformLocation and HashUrlStrategy through ui_web (flutter/engine#41163) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#126486) flutter/engine@ef771f9...a0925f1 2023-05-10 mdebbar@google.com [web] Expose PlatformLocation and HashUrlStrategy through ui_web (flutter/engine#41163) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlatformLocationand its subclassBrowserPlatformLocationthrough the newui_web.HashUrlStrategytoo. It's useful for users who want to extend and customize it instead of building their own from scratch.ui_web/url_strategy.dart=>ui_web/navigation/url_strategy.dart.Issue: flutter/flutter#126831