Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Allow image rasterization/decoding before/without surface acquisition #41168

Merged
merged 12 commits into from Apr 14, 2023

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 13, 2023

This is the same as #41059 with the Android stuff reverted.

This change provides an impeller::Context to the rasterizer so that it can help with snapshotting even if the surface has not been setup yet. It also makes the image decoding logic use that context directly instead of trying to acquire it through a surface, which the rasterizer may or may not have when the image decode is requested.

I originally (incorrectly) believed I'd have to implement the Android side for any of it to work. I think we should still land the Android changes, but this will make for a smaller cherry pick and just leave Android broken (the other patch didn't fix Android with GLES anyway).

Fixes flutter/flutter#124181

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 13, 2023

auto label is removed for flutter/engine, pr: 41168, due to - The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@dnfield
Copy link
Contributor Author

dnfield commented Apr 13, 2023

Failures appear unrelated to this patch, updating branch...

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 13, 2023

auto label is removed for flutter/engine, pr: 41168, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield
Copy link
Contributor Author

dnfield commented Apr 13, 2023

Failures on the mac_host_engine are unrelated to this pr, see #41179

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #41168 at sha c804423

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2023
@auto-submit auto-submit bot merged commit f091060 into flutter:main Apr 14, 2023
37 checks passed
@dnfield dnfield deleted the metal_img_sync branch April 14, 2023 03:03
dnfield added a commit to dnfield/engine that referenced this pull request Apr 14, 2023
…acquisition (flutter#41168)

[Impeller] Allow image rasterization/decoding before/without surface acquisition
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
…acquisition (flutter#41168)

[Impeller] Allow image rasterization/decoding before/without surface acquisition
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2023
CaseyHillers pushed a commit that referenced this pull request Apr 14, 2023
…face … (#41189)

…acquisition (#41168)

[Impeller] Allow image rasterization/decoding before/without surface
acquisition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller will affect goldens
Projects
No open projects
Archived in project
4 participants