[web:canvaskit] move shaders to UniqueRef; fix minor memory leaks #41172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
yjbanov
added
the
autosubmit
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
…utter#41172) [web:canvaskit] move shaders to UniqueRef; fix minor memory leaks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all classes implementing the
Shaderinterface fromManagedSkiaObjecttoUniqueRef.Fix two (probably minor) memory leaks:
CkImageShaderwas leaking intermediate instances ofSkShaderbecause those were neither attached to aFinalizationRegistry, nor disposed of explicitly through thedispose()method.CkFragmentShaderwas leakingSkShaderinstances because it never calledCkFragmentInstance.dispose. Additionally, theCkFragmentInstanceclass isn't really necessary, becauseUniqueRefis fully sufficient to manage instances ofSkShaderobjects for fragment shaders.