Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mac unopt arm builds with arm toolchain #41353

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 20, 2023

Add --force-mac-arm64 to arm gn commands running on Mac ARM bots to compile natively and not with Rosetta. Sometimes we've seen random slow-downs in CI when lots of Rosetta processes run at the same time.

This will disable goma for these builds but it doesn't seem to be much slower:

build ios_debug_sim_arm64 step on prod:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/123894/overview - 1.1 minute
vs this PR:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/747210/overview - 1.8 minute

@jmagman jmagman marked this pull request as ready for review April 20, 2023 01:37
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 20, 2023
@auto-submit auto-submit bot merged commit 3a22f0f into flutter:main Apr 21, 2023
37 checks passed
@jmagman jmagman deleted the arm-unopt branch April 21, 2023 00:13
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request Apr 21, 2023
…125271)

flutter/engine@2db85cb...122c3b3

2023-04-21 737941+loic-sharma@users.noreply.github.com [Windows] Don't
block raster thread until v-blank (flutter/engine#41231)
2023-04-21 chillers@google.com Manual roll skia to d5b4acfb4
(flutter/engine#41378)
2023-04-21 magder@google.com Run mac unopt arm builds with arm toolchain
(flutter/engine#41353)
2023-04-20 zanderso@users.noreply.github.com Revert "re-land "Migrate
mac_host_engine to engine v2 builds." (#41233)"" (flutter/engine#41380)
2023-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from
df05e451b79a to 50b96abe9f6f (1 revision) (flutter/engine#41379)
2023-04-20 109111084+yaakovschectman@users.noreply.github.com Move
ownership of `AccessibilityBridgeWindows` to `FlutterWindowsView`
(flutter/engine#41308)
2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
AoPEjX8Xfq1v0h4kx... to PqBDstaESE_l77k1e... (flutter/engine#41373)
2023-04-20 godofredoc@google.com Revert "Upload windows arm artifacts to
production bucket." (flutter/engine#41372)
2023-04-20 godofredoc@google.com re-land "Migrate mac_host_engine to
engine v2 builds." (#41233)" (flutter/engine#41323)
2023-04-20 godofredoc@google.com Upload windows arm artifacts to
production bucket. (flutter/engine#41324)
2023-04-20 jason-simmons@users.noreply.github.com [Impeller] Change the
default color format for the GLES backend to RGBA (flutter/engine#41342)
2023-04-20 maRci002@users.noreply.github.com [web] change status bar
color based on SystemUiOverlayStyle (flutter/engine#40599)
2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
OcPCdaE17MAihaCrD... to 4OrPF9lzqCKGwBLRh... (flutter/engine#41367)
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from fc09f9b2fb27 to
f4609aa2eaba (1 revision) (flutter/engine#41366)
2023-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from
7d165bd0bb5e to df05e451b79a (2 revisions) (flutter/engine#41365)
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from 80c38970791e to
fc09f9b2fb27 (1 revision) (flutter/engine#41362)
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from c50081c62219 to
80c38970791e (2 revisions) (flutter/engine#41360)
2023-04-20 skia-flutter-autoroll@skia.org Roll Skia from c21e7df194c3 to
c50081c62219 (11 revisions) (flutter/engine#41358)
2023-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
Tun7i4VLz6ncx8JJJ... to AoPEjX8Xfq1v0h4kx... (flutter/engine#41357)
2023-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from
88a3b66b50d6 to 7d165bd0bb5e (1 revision) (flutter/engine#41356)
2023-04-20 jason-simmons@users.noreply.github.com Manual Skia roll from
ad90b6bd4760 to c21e7df194c3 (flutter/engine#41341)
2023-04-20 jonahwilliams@google.com [impeller] convert src over to src
for solid color (flutter/engine#41351)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Tun7i4VLz6nc to PqBDstaESE_l
  fuchsia/sdk/core/mac-amd64 from OcPCdaE17MAi to 4OrPF9lzqCKG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
2 participants