removing the check_gn_format.py file from ci/ #41397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @andoriyaprashant for the PR, can you please update the description with something like: |
|
sure @godofredoc |
godofredoc
approved these changes
Apr 21, 2023
|
@gspencergoog adding you as second reviewer as you were the last person updating the script. Please take a look and let us know it is ok to delete it. |
gspencergoog
approved these changes
Apr 21, 2023
godofredoc
added
the
autosubmit
|
Thank @andoriyaprashant for the fix, it just landed! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 21, 2023
…125324) flutter/engine@dd67063...462e9bb 2023-04-21 30870216+gaaclarke@users.noreply.github.com [impeller] fixed flake where blit wasn't tracking its texture (flutter/engine#41347) 2023-04-21 121665385+andoriyaprashant@users.noreply.github.com removing the check_gn_format.py file from ci/ (flutter/engine#41397) 2023-04-21 ditman@gmail.com [web] Fix HashUrlStrategy.addPopStateListener (flutter/engine#41384) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ditman
pushed a commit
to ditman/flutter-flutter
that referenced
this pull request
Apr 24, 2023
…lutter#125324) flutter/engine@dd67063...462e9bb 2023-04-21 30870216+gaaclarke@users.noreply.github.com [impeller] fixed flake where blit wasn't tracking its texture (flutter/engine#41347) 2023-04-21 121665385+andoriyaprashant@users.noreply.github.com removing the check_gn_format.py file from ci/ (flutter/engine#41397) 2023-04-21 ditman@gmail.com [web] Fix HashUrlStrategy.addPopStateListener (flutter/engine#41384) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete obsolete empty script.
fixes: flutter/flutter#100741
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.