New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Change view ID's type to signed and a typedef #41653
Conversation
Do you plan to cherrypick this for the upcoming release? Otherwise this is a breaking change. |
Whether it's a breaking change also depends on whether we actually break anyone. In this case, I don't think anyone is using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the cleanup!
…126135) flutter/engine@a885ed4...e7cd291 2023-05-05 dkwingsmt@users.noreply.github.com [macOS] Change view ID's type to signed and a typedef (flutter/engine#41653) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR changes the view ID type to
int64_t
and typedef it toFlutterViewId
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.