Migrate SkSurface::getBackend* methods to static functions #41693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
approved these changes
May 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 3, 2023
…126018) flutter/engine@7d70dc8...a0906bd 2023-05-03 bdero@google.com [Impeller] Load instead of restore drawing for non-MSAA passes (flutter/engine#41676) 2023-05-03 jonahwilliams@google.com Remove physical model layer (flutter/engine#41593) 2023-05-03 gspencergoog@users.noreply.github.com Reland: "Determine lifecycle by looking at window focus also" (#41094) (flutter/engine#41702) 2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 887e58fff02f to 93c869da03f5 (12 revisions) (flutter/engine#41705) 2023-05-03 mdebbar@google.com [web] Improve null safety for color->css (flutter/engine#41699) 2023-05-03 mdebbar@google.com [web] Remove unused function parameter (flutter/engine#41700) 2023-05-03 godofredoc@google.com Migrate Android Engine Debug to Engine V2. (flutter/engine#41687) 2023-05-03 kjlubick@users.noreply.github.com Migrate SkSurface::getBackend* methods to static functions (flutter/engine#41693) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://skia-review.googlesource.com/c/skia/+/687642, Skia moved some gpu-related methods on SkSurface to be static functions in a different header. This updates those callsites in Flutter.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.