Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky FlutterChannelsTests, stop mocking NSObject #41747

Merged
merged 1 commit into from May 4, 2023
Merged

Fix flaky FlutterChannelsTests, stop mocking NSObject #41747

merged 1 commit into from May 4, 2023

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented May 4, 2023 •
edited

I don't know why this is only flaking on arm64 Macs, but instead of mocking out NSObject which seems to continue to be mocked on some background thread, instead mock out the more-specific FlutterTaskQueue protocol. My suspicion is that the no class for metaclass is complaining when it tries to get the isa off an object's metaclass NSObject but the whole NSObject class is mocked out at that point? Something like that.

Turn the tests back on.

Fixes flutter/flutter#126013
Reverts #41740

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this May 4, 2023
@jmagman jmagman changed the title Fix flaky FlutterChannelsTest Fix flaky FlutterChannelsTests, stop mocking NSObject May 4, 2023
dnfield
dnfield approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@dnfield
Copy link
Contributor

dnfield commented May 4, 2023

This passed on its first attempt on arm64: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/816996/overview

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label May 4, 2023
@auto-submit auto-submit bot merged commit e206c74 into flutter:main May 4, 2023
27 checks passed
@jmagman jmagman deleted the flake-channels branch May 4, 2023 23:59
@jmagman jmagman mentioned this pull request May 5, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 5, 2023
@engine-flutter-autoroll
e206c74fa Fix flaky FlutterChannelsTests, stop mocking NSObject (fl…
5baadae 
…utter/engine#41747)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 5, 2023
@engine-flutter-autoroll
e206c74fa Fix flaky FlutterChannelsTests, stop mocking NSObject (fl…
4e47da8 
…utter/engine#41747)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 5, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (#…
e9d486c 
…126115)

flutter/engine@4d50706...269ce2d

2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SD8Q_B7eWZqLgqo0f... to de2Eqw0IsOzTq15m3... (flutter/engine#41755)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 00693e987828 to 6577130e14b6 (1 revision) (flutter/engine#41752)
2023-05-04 jacksongardner@google.com Revert "Skwasm Font Loading" (flutter/engine#41750)
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 95e133dbd3a6 to afeed9f8701e (1 revision) (flutter/engine#41749)
2023-05-04 magder@google.com Fix flaky FlutterChannelsTests, stop mocking `NSObject` (flutter/engine#41747)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from a4828415b4af to 00693e987828 (6 revisions) (flutter/engine#41746)
2023-05-04 godofredoc@google.com Migrate linux unopt to engine_v2. (flutter/engine#41658)
2023-05-04 jonahwilliams@google.com [Impeller] check if path is Rect/RRect/Oval (flutter/engine#41744)
2023-05-04 lhkbob@gmail.com Add temporary staging GN arg for Skia roll (flutter/engine#41743)
2023-05-04 jason-simmons@users.noreply.github.com Roll buildroot to 05ec9f7124191c7ba354521f3ffd34b09af872e7 (flutter/engine#41736)
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 7b56aac98a5a to 95e133dbd3a6 (1 revision) (flutter/engine#41741)
2023-05-04 dnfield@google.com Disable flaky tests on arm64 (flutter/engine#41740)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 6950f56ad2ec to a4828415b4af (2 revisions) (flutter/engine#41737)
2023-05-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LIacrdFhuTuHnYh0B... to m0-fwGyFnoDVAvxgk... (flutter/engine#41738)
2023-05-04 jacksongardner@google.com Skwasm Font Loading (flutter/engine#41246)
2023-05-04 godofredoc@google.com Migrate linux_host_engine to engine v2. (flutter/engine#41715)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from LIacrdFhuTuH to m0-fwGyFnoDV
  fuchsia/sdk/core/mac-amd64 from SD8Q_B7eWZqL to de2Eqw0IsOzT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@hellohuanlin
Copy link
Contributor

Ah I remember I had similar issue before. Mocking common objects like NSObject messes up with XCTest code because the XCTest implementation likely also use it. Though it was not architecture dependent in my case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield approved these changes

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios platform-macos
Projects
None yet
Milestone
No milestone
4 participants
@jmagman @dnfield @hellohuanlin @gaaclarke