-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux license engine v2 build. #41797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the initial configuration and builder as bringup.
zanderso
approved these changes
May 8, 2023
godofredoc
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
May 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 8, 2023
…126288) flutter/engine@d9184ce...8d3a816 2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 30a368d502bf to 951eb9653163 (4 revisions) (flutter/engine#41820) 2023-05-08 jacksongardner@google.com Reland "Skwasm Font Loading (flutter/engine#41756) 2023-05-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from KZrdNPIOcs5m2MqV_... to oGF4h14qc40l5ANL3... (flutter/engine#41819) 2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 855e2764c295 to a8b6687327d6 (1 revision) (flutter/engine#41817) 2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 64ba57381c94 to 30a368d502bf (1 revision) (flutter/engine#41816) 2023-05-08 godofredoc@google.com Add linux license engine v2 build. (flutter/engine#41797) 2023-05-08 godofredoc@google.com Windows unopt configuration. (flutter/engine#41785) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from KZrdNPIOcs5m to oGF4h14qc40l If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
godofredoc
added a commit
that referenced
this pull request
May 10, 2023
CP: fc56c86 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the initial configuration and its builder as bringup.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.