[web] Cleanup assertionsEnabled #41829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
commented
May 9, 2023
| // TODO: @yjbanov what's the purpose of this? It's always true. | ||
| assert(refCount == debugReferrers.length); |
There was a problem hiding this comment.
@yjbanov, a question for you :)
During construction, refCount is initialized to 1 and debugReferrers is initialized to an empty set then one item is added.
mdebbar
force-pushed
the
assertionsEnabled
branch
2 times, most recently
from
2655629
to
f759f87
Compare
mdebbar
force-pushed
the
assertionsEnabled
branch
from
f759f87
to
8f16fcf
Compare
mdebbar
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with the rest of the flutter code, this PR explores the possibility of removing our proprietary
assertionsEnabled.