Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backdrop_filter]Avoid relying on internal class details #41873

Merged
merged 2 commits into from
May 10, 2023
Merged

[backdrop_filter]Avoid relying on internal class details #41873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e584e72
Avoid relying on internal class details
hellohuanlin May 9, 2023
b873ff8
also fix visual effect subview
hellohuanlin May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm
View file
Open in desktop
Expand Up @@ -1215,7 +1215,7 @@ - (void)testApplyBackdropFilterAPIChangedNoGaussianBlurFilter {
initWithEffect:[UIBlurEffect effectWithStyle:UIBlurEffectStyleLight]];
NSArray* subviews = editedUIVisualEffectView.subviews;
for (UIView* view in subviews) {
if ([view isKindOfClass:NSClassFromString(@"_UIVisualEffectBackdropView")]) {
if ([NSStringFromClass([view class]) hasSuffix:@"BackdropView"]) {
for (CIFilter* filter in view.layer.filters) {
if ([[filter valueForKey:@"name"] isEqual:@"gaussianBlur"]) {
[filter setValue:@"notGaussianBlur" forKey:@"name"];
Expand All @@ -1238,7 +1238,7 @@ - (void)testApplyBackdropFilterAPIChangedInvalidInputRadius {
initWithEffect:[UIBlurEffect effectWithStyle:UIBlurEffectStyleLight]];
NSArray* subviews = editedUIVisualEffectView.subviews;
for (UIView* view in subviews) {
if ([view isKindOfClass:NSClassFromString(@"_UIVisualEffectBackdropView")]) {
if ([NSStringFromClass([view class]) hasSuffix:@"BackdropView"]) {
for (CIFilter* filter in view.layer.filters) {
if ([[filter valueForKey:@"name"] isEqual:@"gaussianBlur"]) {
[filter setValue:@"invalidInputRadius" forKey:@"inputRadius"];
Expand All @@ -1265,7 +1265,7 @@ - (void)testBackdropFilterVisualEffectSubviewBackgroundColor {
visualEffectView:visualEffectView];
CGColorRef visualEffectSubviewBackgroundColor;
for (UIView* view in [platformViewFilter backdropFilterView].subviews) {
if ([view isKindOfClass:NSClassFromString(@"_UIVisualEffectSubview")]) {
if ([NSStringFromClass([view class]) hasSuffix:@"VisualEffectSubview"]) {
visualEffectSubviewBackgroundColor = view.layer.backgroundColor;
}
}
Expand Down Expand Up @@ -2773,7 +2773,7 @@ - (BOOL)validateOneVisualEffectView:(UIView*)visualEffectView
inputRadius:(CGFloat)inputRadius {
XCTAssertTrue(CGRectEqualToRect(visualEffectView.frame, frame));
for (UIView* view in visualEffectView.subviews) {
if (![view isKindOfClass:NSClassFromString(@"_UIVisualEffectBackdropView")]) {
if (![NSStringFromClass([view class]) hasSuffix:@"BackdropView"]) {
continue;
}
XCTAssertEqual(view.layer.filters.count, 1u);
Expand Down
4 changes: 2 additions & 2 deletions shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm
View file
Open in desktop
Expand Up @@ -121,7 +121,7 @@ + (void)prepareOnce:(UIVisualEffectView*)visualEffectView {
}
for (NSUInteger i = 0; i < visualEffectView.subviews.count; i++) {
UIView* view = visualEffectView.subviews[i];
if ([view isKindOfClass:NSClassFromString(@"_UIVisualEffectBackdropView")]) {
if ([NSStringFromClass([view class]) hasSuffix:@"BackdropView"]) {
_indexOfBackdropView = i;
for (NSObject* filter in view.layer.filters) {
if ([[filter valueForKey:@"name"] isEqual:@"gaussianBlur"] &&
Expand All @@ -130,7 +130,7 @@ + (void)prepareOnce:(UIVisualEffectView*)visualEffectView {
break;
}
}
} else if ([view isKindOfClass:NSClassFromString(@"_UIVisualEffectSubview")]) {
} else if ([NSStringFromClass([view class]) hasSuffix:@"VisualEffectSubview"]) {
_indexOfVisualEffectSubview = i;
}
}
Expand Down