Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Re-enable history tests on Safari #41901

Merged
merged 2 commits into from
May 10, 2023
Merged

[web] Re-enable history tests on Safari #41901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37f74de
[web] Re-enable history tests on Safari
mdebbar May 10, 2023
accd242
Merge branch 'main' into enable_history_test_safari
mdebbar May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions lib/web_ui/test/engine/history_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(mdebbar): https://github.com/flutter/flutter/issues/51169
@TestOn('!safari')
library;

import 'dart:async';
import 'dart:js_interop'
show JSExportedDartFunction, JSExportedDartFunctionToFunction;
Expand All @@ -14,7 +10,6 @@ import 'package:quiver/testing/async.dart';
import 'package:test/bootstrap/browser.dart';
import 'package:test/test.dart';
import 'package:ui/src/engine.dart' show window;
import 'package:ui/src/engine/browser_detection.dart';
import 'package:ui/src/engine/dom.dart'
show DomEvent, DomEventListener, createDomPopStateEvent;
import 'package:ui/src/engine/navigation.dart';
Expand Down Expand Up @@ -285,7 +280,7 @@ void testMain() {
// 3. The active entry doesn't belong to our history anymore because we
// navigated past it.
expect(originalStrategy.currentEntryIndex, -1);
}, skip: browserEngine == BrowserEngine.webkit);
});

test('handle user-provided url', () async {
final TestUrlStrategy strategy = TestUrlStrategy.fromEntry(
Expand Down Expand Up @@ -522,7 +517,7 @@ void testMain() {
expect(strategy.currentEntryIndex, 0);
expect(strategy.currentEntry.state, _tagStateWithSerialCount('initial state', 0));
expect(strategy.currentEntry.url, '/home');
}, skip: browserEngine == BrowserEngine.webkit);
});

test('handle user-provided url', () async {
final TestUrlStrategy strategy = TestUrlStrategy.fromEntry(
Expand Down