Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move linux fuchsia engine v2 build to prod." #41902

Merged
merged 1 commit into from
May 10, 2023

Conversation

zanderso
Copy link
Member

Reverts #41865

Failing a framework test on presubmit: flutter/flutter#126452

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Member

@zanderso
Copy link
Member Author

Landing revert eagerly to get the framework roll unblocked.

@zanderso zanderso merged commit 892f88d into main May 10, 2023
7 of 31 checks passed
@zanderso zanderso deleted the revert-41865-move_linux_fuchsia branch May 10, 2023 18:46
zanderso pushed a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request May 10, 2023
…sions) (#126455)

Manual roll requested by aaclarke@google.com

Cannot build log URL because revision "892f88d2513f" is invalid: Luci
builds of "Linux Fuchsia FEMU" for
892f88d2513f4a60ebd6d1496c4ac272e53c55ba was STARTED

2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request May 10, 2023
…126468)

flutter/engine@10ac36c...406b354

2023-05-10 mdebbar@google.com [web] Re-enable history tests on Safari
(flutter/engine#41901)
2023-05-10 flar@google.com switch from MockCanvas to DisplayListBuilder
in layer unit tests (flutter/engine#41889)
2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…sions) (flutter#126455)

Manual roll requested by aaclarke@google.com

Cannot build log URL because revision "892f88d2513f" is invalid: Luci
builds of "Linux Fuchsia FEMU" for
892f88d2513f4a60ebd6d1496c4ac272e53c55ba was STARTED

2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#126468)

flutter/engine@10ac36c...406b354

2023-05-10 mdebbar@google.com [web] Re-enable history tests on Safari
(flutter/engine#41901)
2023-05-10 flar@google.com switch from MockCanvas to DisplayListBuilder
in layer unit tests (flutter/engine#41889)
2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants