[macos] Disable background colour tests #41904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are flaky. Until they've been deflaked, disable the following two tests: * FlutterEngineTest.BackgroundIsBlack * FlutterEngineTest.CanOverrideBackgroundColor Issue: flutter/flutter#124677
zanderso
approved these changes
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 11, 2023
…126481) flutter/engine@de6e130...ef771f9 2023-05-10 chris@bracken.jp [macos] Disable background colour tests (flutter/engine#41904) 2023-05-10 yjbanov@google.com [web] generalize focusability in semantics (flutter/engine#41831) 2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 32f4cfc2460b to 1a29bd9a0147 (12 revisions) (flutter/engine#41905) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#126481) flutter/engine@de6e130...ef771f9 2023-05-10 chris@bracken.jp [macos] Disable background colour tests (flutter/engine#41904) 2023-05-10 yjbanov@google.com [web] generalize focusability in semantics (flutter/engine#41831) 2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 32f4cfc2460b to 1a29bd9a0147 (12 revisions) (flutter/engine#41905) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are flaky. Until they've been deflaked, disable the following two tests:
Issue: flutter/flutter#124677
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.