Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GN staging flag for save layer bounds #41940

Merged
merged 1 commit into from May 11, 2023
Merged

Remove GN staging flag for save layer bounds #41940

merged 1 commit into from May 11, 2023

Conversation

lhkbob
Copy link
Contributor

@lhkbob lhkbob commented May 11, 2023

See skbug.com/12083, skbug.com/12303.

SkCanvas::saveLayer() calls with an SkColorFilter that affects transparent black will now fill out to the bounds of the clip before the layer, which prevents leaking internal layer allocation decisions in the final rendering.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@lhkbob
Remove GN staging flag for save layer bounds
ec14be8 
See skbug.com/12083, skbug.com/12303.

SkCanvas::saveLayer() calls with an SkColorFilter that affects transparent black will now fill out to the bounds of the clip before the layer, which prevents leaking internal layer allocation decisions in the final rendering.
@lhkbob lhkbob mentioned this pull request May 11, 2023
Closed
8 tasks
flar
flar approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label May 11, 2023
@auto-submit auto-submit bot merged commit a491992 into flutter:main May 11, 2023
30 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2023
@engine-flutter-autoroll
a49199258 Remove GN staging flag for save layer bounds (flutter/engin…
3b2afc8 
…e#41940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2023
@engine-flutter-autoroll
a49199258 Remove GN staging flag for save layer bounds (flutter/engin…
4064a3b 
…e#41940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2023
@engine-flutter-autoroll
a49199258 Remove GN staging flag for save layer bounds (flutter/engin…
2b8e049 
…e#41940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2023
@engine-flutter-autoroll
a49199258 Remove GN staging flag for save layer bounds (flutter/engin…
1d8fbd5 
…e#41940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 11, 2023
@engine-flutter-autoroll
a49199258 Remove GN staging flag for save layer bounds (flutter/engin…
70de791 
…e#41940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2023
@engine-flutter-autoroll
a49199258 Remove GN staging flag for save layer bounds (flutter/engin…
0a018c9 
…e#41940)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 12, 2023
@engine-flutter-autoroll
Roll Flutter Engine from f38f46f66e9a to 748ef964b993 (13 revisions) (#…
43b2b65 
…126622)

flutter/engine@f38f46f...748ef96

2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from aed81125e6bc to ccec5093ca38 (10 revisions) (flutter/engine#41963)
2023-05-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 2tQjI0g3aDmjHAtMw... to MjcKzcsqMDkuRKopu... (flutter/engine#41960)
2023-05-11 smartercallum@gmail.com iPhone floating cursor selection (flutter/engine#36643)
2023-05-11 vashworth@google.com Update README.md (flutter/engine#41953)
2023-05-11 skia-flutter-autoroll@skia.org Roll Clang from 5344d8e10bb7 to 6d667d4b261e (flutter/engine#41949)
2023-05-11 kjlubick@users.noreply.github.com Use moved SkImage procs (flutter/engine#41947)
2023-05-11 msgh@selfisekai.rocks allow supplying custom gn args in gn wrapper (flutter/engine#41794)
2023-05-11 68549184+Mayb3Nots@users.noreply.github.com fix: platform_dispatcher documentation typo (flutter/engine#41739)
2023-05-11 lhkbob@gmail.com Remove GN staging flag for save layer bounds (flutter/engine#41940)
2023-05-11 flar@google.com switch MockTexture off of MockCanvas calls (flutter/engine#41906)
2023-05-11 gspencergoog@users.noreply.github.com [Android] Lifecycle defaults to focused instead of unfocused (flutter/engine#41875)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from ccf73af6ca91 to aed81125e6bc (9 revisions) (flutter/engine#41946)
2023-05-11 godofredoc@google.com Clobber caches in licenses test. (flutter/engine#41942)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 2tQjI0g3aDmj to MjcKzcsqMDku

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers added a commit that referenced this pull request May 14, 2023
@CaseyHillers
Revert "Remove GN staging flag for save layer bounds (#41940)"
af19af2 
This reverts commit a491992.
@CaseyHillers CaseyHillers mentioned this pull request May 14, 2023
Merged
@CaseyHillers
Copy link
Contributor

FYI I sent a revert in #42026 since this broke a scuba in Google Testing. See b/282115120

auto-submit bot pushed a commit that referenced this pull request May 14, 2023
Revert "Remove GN staging flag for save layer bounds" (#42026)
dd8d76d 
Reverts #41940

See b/282115120

This caused a golden failure on Google Testing where a rectangular avatar became circular.
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Flutter Engine from f38f46f66e9a to 748ef964b993 (13 revisions) (f…
a1c1a24 
…lutter#126622)

flutter/engine@f38f46f...748ef96

2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from aed81125e6bc to ccec5093ca38 (10 revisions) (flutter/engine#41963)
2023-05-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 2tQjI0g3aDmjHAtMw... to MjcKzcsqMDkuRKopu... (flutter/engine#41960)
2023-05-11 smartercallum@gmail.com iPhone floating cursor selection (flutter/engine#36643)
2023-05-11 vashworth@google.com Update README.md (flutter/engine#41953)
2023-05-11 skia-flutter-autoroll@skia.org Roll Clang from 5344d8e10bb7 to 6d667d4b261e (flutter/engine#41949)
2023-05-11 kjlubick@users.noreply.github.com Use moved SkImage procs (flutter/engine#41947)
2023-05-11 msgh@selfisekai.rocks allow supplying custom gn args in gn wrapper (flutter/engine#41794)
2023-05-11 68549184+Mayb3Nots@users.noreply.github.com fix: platform_dispatcher documentation typo (flutter/engine#41739)
2023-05-11 lhkbob@gmail.com Remove GN staging flag for save layer bounds (flutter/engine#41940)
2023-05-11 flar@google.com switch MockTexture off of MockCanvas calls (flutter/engine#41906)
2023-05-11 gspencergoog@users.noreply.github.com [Android] Lifecycle defaults to focused instead of unfocused (flutter/engine#41875)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from ccf73af6ca91 to aed81125e6bc (9 revisions) (flutter/engine#41946)
2023-05-11 godofredoc@google.com Clobber caches in licenses test. (flutter/engine#41942)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 2tQjI0g3aDmj to MjcKzcsqMDku

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

@flar flar flar approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
4 participants
@lhkbob @CaseyHillers @jason-simmons @flar