Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile skwasm at -Oz. #42002

Merged
merged 2 commits into from May 15, 2023
Merged

Compile skwasm at -Oz. #42002

merged 2 commits into from May 15, 2023

Conversation

eyebrowsoffire
Copy link
Contributor

We want to start from a place of small size, and optimize from there with skwasm. Since there is no baseline expectation of performance at -O3, let's start with the smallest possible binary.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 12, 2023
@eyebrowsoffire eyebrowsoffire marked this pull request as ready for review May 12, 2023 23:40
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit auto-submit bot merged commit 86e5f77 into flutter:main May 15, 2023
30 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 16, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 16, 2023
…126894)

flutter/engine@027ca79...c4d4b40

2023-05-15 ychris@google.com Fix upload xcresult script in run_tests.py (flutter/engine#42056)
2023-05-15 jonahwilliams@google.com [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054)
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058)
2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057)
2023-05-15 bdero@google.com [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055)
2023-05-15 jacksongardner@google.com Compile skwasm at -Oz. (flutter/engine#42002)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#126894)

flutter/engine@027ca79...c4d4b40

2023-05-15 ychris@google.com Fix upload xcresult script in run_tests.py (flutter/engine#42056)
2023-05-15 jonahwilliams@google.com [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054)
2023-05-15 skia-flutter-autoroll@skia.org Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058)
2023-05-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057)
2023-05-15 bdero@google.com [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055)
2023-05-15 jacksongardner@google.com Compile skwasm at -Oz. (flutter/engine#42002)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
2 participants