New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Do not bounce editing state back to framework on setEditState #42091
Conversation
4675f7e
to
0a10d3e
Compare
… verify the editing state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍.
I'm glad to see this go! Have you tested it locally just to make sure nothing obvious breaks?
Yeah nothing obvious broke, I tried CJK input as well and seems to be working as expected. |
…127720) flutter/engine@3b5b5fc...795db50 2023-05-26 rmolivares@renzo-olivares.dev [macOS] Do not bounce editing state back to framework on setEditState (flutter/engine#42091) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Some context for this change flutter/flutter#118642 (comment) and flutter/flutter#118759 (comment) . Tldr, the use-case that this bouncing was originally introduced for in #13702 is no longer an issue.
This ack response is also not present on other desktop platforms or iOS.
Fixes #118759 and #118642
Pre-launch Checklist
///
).