[macOS] Clean up PlatformView mutator scaling #42110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cbracken
changed the title
|
test-exempt: code refactor with no semantic change |
shell/platform/darwin/macos/framework/Source/FlutterMutatorView.mm
Outdated
Show resolved
Hide resolved
When applying platform view mutators, the mutations array includes a transform from logical to physical coordinates. Since Cocoa deals only in logical points, we inject a physical to logical coordinate transform to counteract this. Rather than applying this multiple times throughout the `[FlutterMutatorView applyFlutterLayer]` method we gather a list of transforms that includes the additional physical to logical scale transform. This change is a cleanup change for readability and makes no semantic changes to how mutator views are applied. Existing unit tests in FlutterMutatorViewTest.mm are expected to pass without changes.
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 18, 2023
…127116) flutter/engine@a22dd64...843ce0b 2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from a3a9fb5f4a31 to ad8fa4a38668 (1 revision) (flutter/engine#42121) 2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f6fabbe9fba to 1991015ad460 (4 revisions) (flutter/engine#42120) 2023-05-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wNfsef5we4l8hxEII... to jNFpQ1gTCMNbzSZCw... (flutter/engine#42118) 2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from caff30d16ae7 to a3a9fb5f4a31 (1 revision) (flutter/engine#42117) 2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from ffa425bacfc4 to caff30d16ae7 (29 revisions) (flutter/engine#42116) 2023-05-18 chris@bracken.jp [macOS] Clean up PlatformView mutator scaling (flutter/engine#42110) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from wNfsef5we4l8 to jNFpQ1gTCMNb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127116) flutter/engine@a22dd64...843ce0b 2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from a3a9fb5f4a31 to ad8fa4a38668 (1 revision) (flutter/engine#42121) 2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f6fabbe9fba to 1991015ad460 (4 revisions) (flutter/engine#42120) 2023-05-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from wNfsef5we4l8hxEII... to jNFpQ1gTCMNbzSZCw... (flutter/engine#42118) 2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from caff30d16ae7 to a3a9fb5f4a31 (1 revision) (flutter/engine#42117) 2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from ffa425bacfc4 to caff30d16ae7 (29 revisions) (flutter/engine#42116) 2023-05-18 chris@bracken.jp [macOS] Clean up PlatformView mutator scaling (flutter/engine#42110) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from wNfsef5we4l8 to jNFpQ1gTCMNb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying platform view mutators, the mutations array includes a transform from logical to physical coordinates. Since Cocoa deals only in logical points, we inject a physical to logical coordinate transform to counteract this.
Rather than applying this multiple times throughout the
[FlutterMutatorView applyFlutterLayer]method we gather a list of transforms that includes the additional physical to logical scale transform.This change is a cleanup change for readability and makes no semantic changes to how mutator views are applied. Existing unit tests in FlutterMutatorViewTest.mm are expected to pass without changes.
This is refactoring prior to applying a fix for rotation handling.
Issue: flutter/flutter#124490
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.