-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll Skia from 2ffed2e4c6f8 to 8931359a74f1 (4 revisions) #42139
Merged
auto-submit
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:skia-flutter-autoroll-d4f3c7cd-b286-4a48-957e-395500cd4de1-1684450053
May 18, 2023
Merged
Roll Skia from 2ffed2e4c6f8 to 8931359a74f1 (4 revisions) #42139
auto-submit
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:skia-flutter-autoroll-d4f3c7cd-b286-4a48-957e-395500cd4de1-1684450053
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/2ffed2e4c6f8..8931359a74f1 2023-05-18 johnstiles@google.com Always add braces when writing child statements in WGSL. 2023-05-18 johnstiles@google.com Eliminate DSLFunction entirely. 2023-05-18 michaelludwig@google.com [skif] Delete legacy SkColorFilterImageFilter impl 2023-05-18 michaelludwig@google.com [skif] Don't evaluate empty-source filters for SkNoDrawCanvases If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
981f089
to
6bb00c7
Compare
fluttergithubbot
approved these changes
May 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 19, 2023
…127154) flutter/engine@3c23dda...9039c2d 2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from 2ffed2e4c6f8 to 8931359a74f1 (4 revisions) (flutter/engine#42139) 2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7bc022c51215 to 95b96a9f498a (2 revisions) (flutter/engine#42138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127154) flutter/engine@3c23dda...9039c2d 2023-05-18 skia-flutter-autoroll@skia.org Roll Skia from 2ffed2e4c6f8 to 8931359a74f1 (4 revisions) (flutter/engine#42139) 2023-05-18 skia-flutter-autoroll@skia.org Roll Dart SDK from 7bc022c51215 to 95b96a9f498a (2 revisions) (flutter/engine#42138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/2ffed2e4c6f8..8931359a74f1
2023-05-18 johnstiles@google.com Always add braces when writing child statements in WGSL.
2023-05-18 johnstiles@google.com Eliminate DSLFunction entirely.
2023-05-18 michaelludwig@google.com [skif] Delete legacy SkColorFilterImageFilter impl
2023-05-18 michaelludwig@google.com [skif] Don't evaluate empty-source filters for SkNoDrawCanvases
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md