[macOS] Extract PlatformView mutator clip updating #42164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts `updatePathClipViewsWithPaths:origin:` which updates the stack of AppKit clip views hosting the platform view. This change is a cleanup change for readability and makes no semantic changes to how mutator views are applied. Existing unit tests in [FlutterMutatorViewTest.mm](https://github.com/flutter/engine/blob/main/shell/platform/darwin/macos/framework/Source/FlutterMutatorViewTest.mm) are expected to pass without changes. This is refactoring prior to applying a fix for rotation handling. Issue: flutter/flutter#124490
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cbracken
commented
May 19, 2023
cbracken
commented
May 19, 2023
cbracken
commented
May 19, 2023
|
test-exempt: code refactor with no semantic change |
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 19, 2023
…127233) flutter/engine@3267fa2...f0c02ae 2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eal6a4HeaQon_Y4ml... to TWjmvLCOnYAUgAzvT... (flutter/engine#42168) 2023-05-19 chris@bracken.jp [macOS] Extract PlatformView mutator clip updating (flutter/engine#42164) 2023-05-19 110993981+htoor3@users.noreply.github.com [web] Fix event offset for transformed widgets (and text input nodes). (flutter/engine#41870) 2023-05-19 zanderso@users.noreply.github.com Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/engine#42166) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from eal6a4HeaQon to TWjmvLCOnYAU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127233) flutter/engine@3267fa2...f0c02ae 2023-05-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from eal6a4HeaQon_Y4ml... to TWjmvLCOnYAUgAzvT... (flutter/engine#42168) 2023-05-19 chris@bracken.jp [macOS] Extract PlatformView mutator clip updating (flutter/engine#42164) 2023-05-19 110993981+htoor3@users.noreply.github.com [web] Fix event offset for transformed widgets (and text input nodes). (flutter/engine#41870) 2023-05-19 zanderso@users.noreply.github.com Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/engine#42166) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from eal6a4HeaQon to TWjmvLCOnYAU If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts
updatePathClipViewsWithPaths:origin:which updates the stack of AppKit clip views hosting the platform view.This change is a cleanup change for readability and makes no semantic changes to how mutator views are applied. Existing unit tests in FlutterMutatorViewTest.mm are expected to pass without changes.
This is refactoring prior to applying a fix for rotation handling.
Issue: flutter/flutter#124490
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.