New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Skwasm] Implement miscellaneous drawing APIs #42324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
…127630) flutter/engine@6a4e675...ff04d2f 2023-05-25 flar@google.com Move checkerboard unit tests onto DisplayList mechanism (flutter/engine#41951) 2023-05-25 jacksongardner@google.com [Skwasm] Implement miscellaneous drawing APIs (flutter/engine#42324) 2023-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from X4uS4T6_J-VUh9M4A... to AgIKKqtBtb6RJnyI9... (flutter/engine#42326) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from X4uS4T6_J-VU to AgIKKqtBtb6R If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Implements
drawVertices
,drawPoints
, anddrawAtlas
.These are the last rendering APIs that are unimplemented in Skwasm! (Although we still need to add platform view support).