Reland: "Adding app lifecycle notification for macOS and Linux, add hidden state." (#40542)
#42418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hidden` state." (flutter#42384) This reverts commit 57e491a to fix the lint warnings.
flutter-dashboard
bot
added
platform-android
platform-linux
platform-macos
platform-web
gspencergoog
changed the title
hidden state." (#42384)hidden state." (#40542)
gspencergoog
force-pushed
the
app_lifecycle
branch
from
9b0eb5f
to
1da6cd8
Compare
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
…nux, add `hidden` state." (flutter#40542) (flutter/engine#42418)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
…nux, add `hidden` state." (flutter#40542) (flutter/engine#42418)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
…nux, add `hidden` state." (flutter#40542) (flutter/engine#42418)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
…nux, add `hidden` state." (flutter#40542) (flutter/engine#42418)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2023
…127890) flutter/engine@a6d3124...1ba8091 2023-05-30 jhy03261997@gmail.com Handle a11y focus event on Ios and android (flutter/engine#41777) 2023-05-30 matej.knopp@gmail.com Fix unitialized SkRect (flutter/engine#42403) 2023-05-30 reidbaker@google.com Update engine testing to use api 33 for android tests. (flutter/engine#42351) 2023-05-30 gspencergoog@users.noreply.github.com Reland: "Adding app lifecycle notification for macOS and Linux, add `hidden` state." (#40542) (flutter/engine#42418) 2023-05-30 30870216+gaaclarke@users.noreply.github.com [Impeller] Fixed GlyphAtlasWithLotsOfdUniqueGlyphSize (flutter/engine#42423) 2023-05-30 54558023+keyonghan@users.noreply.github.com Remove legacy xcode properties/dependencies (flutter/engine#42368) 2023-05-30 skia-flutter-autoroll@skia.org Roll Skia from bab82f14da1a to fed417995ba9 (7 revisions) (flutter/engine#42424) 2023-05-30 30870216+gaaclarke@users.noreply.github.com [Impeller] removed vulkan unit test csv (flutter/engine#42354) 2023-05-30 skia-flutter-autoroll@skia.org Roll Skia from d22106cc40a0 to bab82f14da1a (7 revisions) (flutter/engine#42420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 8, 2023
#123274) ## Description This adds `AppLifecycleListener`, a class for listening to changes in the application lifecycle, and responding to requests to exit the application. It depends on changes in the Engine that add new lifecycle states: flutter/engine#42418 Here's a diagram for the lifecycle states. I'll add a similar diagram to the documentation for these classes.  ## Related Issues - #30735 ## Tests - Added tests for new lifecycle value, as well as for the `AppLifecycleListener` itself.
This was referenced Jul 21, 2023
0xZOne
added a commit
to 0xZOne/flutter_boost
that referenced
this pull request
Jan 6, 2024
Fix the following exception:
══╡ EXCEPTION CAUGHT BY SERVICES LIBRARY ╞══════════════════════════════════════════════════════════
The following assertion was thrown during a platform message callback:
Invalid lifecycle state transition generated from AppLifecycleState.resumed to
AppLifecycleState.detached (generated [AppLifecycleState.detached])
'package:flutter/src/services/binding.dart':
Failed assertion: line 296 pos 12: '(){
AppLifecycleState? starting = previousState;
for (final AppLifecycleState ending in stateChanges) {
if (!_debugVerifyLifecycleChange(starting, ending)) {
return false;
}
starting = ending;
}
return true;
}()'
Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=2_bug.yml
When the exception was thrown, this was the stack:
(elided 4 frames from class _AssertionError and dart:async)
════════════════════════════════════════════════════════════════════════════════════════════════════
See also: flutter/engine#42418
0xZOne
added a commit
to alibaba/flutter_boost
that referenced
this pull request
Jan 6, 2024
Fix the following exception:
══╡ EXCEPTION CAUGHT BY SERVICES LIBRARY ╞══════════════════════════════════════════════════════════
The following assertion was thrown during a platform message callback:
Invalid lifecycle state transition generated from AppLifecycleState.resumed to
AppLifecycleState.detached (generated [AppLifecycleState.detached])
'package:flutter/src/services/binding.dart':
Failed assertion: line 296 pos 12: '(){
AppLifecycleState? starting = previousState;
for (final AppLifecycleState ending in stateChanges) {
if (!_debugVerifyLifecycleChange(starting, ending)) {
return false;
}
starting = ending;
}
return true;
}()'
Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=2_bug.yml
When the exception was thrown, this was the stack:
(elided 4 frames from class _AssertionError and dart:async)
════════════════════════════════════════════════════════════════════════════════════════════════════
See also: flutter/engine#42418
goderbauer
reviewed
Feb 1, 2024
| @@ -805,55 +805,75 @@ - (nonnull NSView*)createWithViewIdentifier:(int64_t)viewId arguments:(nullable | |||
| EXPECT_TRUE(announced); | |||
| } | |||
|
|
|||
| TEST_F(FlutterEngineTest, RunWithEntrypointUpdatesDisplayConfig) { | |||
There was a problem hiding this comment.
Presumably, it wasn't the intention of this PR to remove this test and the next one? Probably just a bad merge?
There was a problem hiding this comment.
Huh. No, definitely not intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 57e491a to re-land #40542 to fix the lint warning which caused the original PR to be reverted (the lint warnings were turned on after the original was landed, which is why it wasn't caught earlier).