Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all the uses of master branch in the .ci.yaml file. #42679

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Remove all the uses of master branch in the .ci.yaml file. #42679

merged 2 commits into from
Jun 8, 2023

Conversation

godofredoc
Copy link
Contributor

Master branch is not the default branch in the engine anymore and we should not run any builds on it.

Bug: flutter/flutter#90476

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove all the uses of master branch in the .ci.yaml file.
9bcacae 
Master branch is not the default branch in the engine anymore and we
should not run any builds on it.

Bug: flutter/flutter#90476
@godofredoc godofredoc requested a review from zanderso June 8, 2023 21:01
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit auto-submit bot merged commit 87851c3 into flutter:main Jun 8, 2023
32 checks passed
@godofredoc godofredoc deleted the remove_master_uses branch June 8, 2023 23:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
87851c37a Remove all the uses of master branch in the .ci.yaml file. (f…
2e54f87 
…lutter/engine#42679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
87851c37a Remove all the uses of master branch in the .ci.yaml file. (f…
0354c33 
…lutter/engine#42679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
87851c37a Remove all the uses of master branch in the .ci.yaml file. (f…
6e7f253 
…lutter/engine#42679)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
87851c37a Remove all the uses of master branch in the .ci.yaml file. (f…
865e8bf 
…lutter/engine#42679)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revi…
80b9ac2 
…sions) (#128554)

Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions)

Manual roll requested by zra@google.com

flutter/engine@a5f7d5d...8f9e608

2023-06-09 zanderso@users.noreply.github.com Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688)
2023-06-09 mk12360@gmail.com [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667)
2023-06-09 bdero@google.com [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687)
2023-06-09 godofredoc@google.com Document the use of realm in archives. (flutter/engine#42682)
2023-06-09 skia-flutter-autoroll@skia.org Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684)
2023-06-08 godofredoc@google.com Prevent double upload of benchmarks. (flutter/engine#42683)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680)
2023-06-08 godofredoc@google.com Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679)
2023-06-08 godofredoc@google.com Replace benchmarks with its v2 version. (flutter/engine#42677)
2023-06-08 bdero@google.com [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678)
2023-06-08 bdero@google.com [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673)
2023-06-08 rmolivares@renzo-olivares.dev [Linux] composing delta fixes (flutter/engine#42648)
2023-06-08 jinhe.zjh@alibaba-inc.com Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409)
2023-06-08 zanderso@users.noreply.github.com Fix license hash (flutter/engine#42675)
2023-06-08 zanderso@users.noreply.github.com Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670)
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668)
2023-06-08 jonahwilliams@google.com [Impeller] sort all vertex inputs by location. (flutter/engine#42664)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662)
2023-06-08 zanderso@users.noreply.github.com Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660)
2023-06-08 skia-flutter-autoroll@skia.org Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659)
2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658)
2023-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655)
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657)
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651)
2023-06-08 godofredoc@google.com Benchmarks configurations for engine v2. (flutter/engine#42622)
2023-06-08 skia-flutter-autoroll@skia.org Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645)
2023-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646)
2023-06-07 aam@google.com Roll dart to 3.1.0-180.0.dev (flutter/engine#42638)
2023-06-07 skia-flutter-autoroll@skia.org Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from aMTaMP0DdKdJ to lPCv1NshK-tv
  fuchsia/sdk/core/mac-amd64 from DL1QQ5eZRVNA to ukXXOXtI7uRI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
2 participants
@godofredoc @zanderso