[GN] Don't set dart_host_toolchain #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Nov 1, 2017
zanderso
force-pushed
the
rm-dart-host-toolchain
branch
from
280252d
to
309ca25
Compare
whesse
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 1, 2017
This flag can be removed after: flutter/engine#4308 lands. Change-Id: I4730aaece1e43cf71ea569bda78c2cd546a66358 Reviewed-on: https://dart-review.googlesource.com/18060 Reviewed-by: Alexander Aprelev <aam@google.com>
mravn-google
added a commit
that referenced
this pull request
Nov 2, 2017
This reverts commit 4caa68b.
mravn-google
added a commit
that referenced
this pull request
Nov 2, 2017
zanderso
added a commit
to flutter/buildroot
that referenced
this pull request
Nov 2, 2017
This will allow flutter/engine#4308 to be relanded.
zanderso
added a commit
to flutter/buildroot
that referenced
this pull request
Nov 2, 2017
This will allow flutter/engine#4308 to be relanded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for setting the right host toolchain is already in the GN files and is selected when we set host_cpu to x86 during a crossbuild with a 32-bit target. This change also rolls the buildroot to pick up flutter/buildroot@5eb993a