Add a note in ImeSyncDeferringInsetsCallback explaining the reason behind capturing the latest final inset state #43109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hind capturing the latest final inset state
reidbaker
approved these changes
Jun 23, 2023
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
… reason behind capturing the latest final inset state (flutter/engine#43109)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
… reason behind capturing the latest final inset state (flutter/engine#43109)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
… reason behind capturing the latest final inset state (flutter/engine#43109)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 23, 2023
…129437) flutter/engine@27f3498...cd30a48 2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 04fa1c1ef69c to 9635d54210dc (2 revisions) (flutter/engine#43145) 2023-06-23 skia-flutter-autoroll@skia.org Roll ANGLE from 9211ebf1f2ac to 2e285bb591f7 (1 revision) (flutter/engine#43144) 2023-06-23 34871572+gmackall@users.noreply.github.com Add a note in ImeSyncDeferringInsetsCallback explaining the reason behind capturing the latest final inset state (flutter/engine#43109) 2023-06-23 skia-flutter-autoroll@skia.org Roll Skia from 6ab865ee1f65 to 04fa1c1ef69c (1 revision) (flutter/engine#43141) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solely documentation change to explain the reasoning behind the change in #42700.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.