Revert "Refactor JSNumber.toDart and Object.toJS" #43286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca41476. Reason for reverting: Broke the roll into the framework.
|
See more context about the revert: https://discord.com/channels/608014603317936148/1123298130671194173 |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 43286, due to - The status or check suite Linux linux_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
ricardoamador
added
the
revert
auto-submit
bot
removed
the
revert
|
A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id' |
srujzs
added
the
revert
fluttergithubbot
approved these changes
Jun 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 28, 2023
…129682) flutter/engine@7c7c45d...25a5850 2023-06-27 58529443+srujzs@users.noreply.github.com Revert "Refactor JSNumber.toDart and Object.toJS" (flutter/engine#43286) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Reverts flutter#43149 Reason for reverting: Broke the roll into the framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #43149
Reason for reverting: Broke the roll into the framework.
Pre-launch Checklist
///).