-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll Skia from 743ad92f5de2 to 52613fcc0780 (9 revisions) #43655
Merged
auto-submit
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:skia-flutter-autoroll-3404fe99-2bbe-4848-897c-e566560e5fe9-1689284040
Jul 13, 2023
Merged
Roll Skia from 743ad92f5de2 to 52613fcc0780 (9 revisions) #43655
auto-submit
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:skia-flutter-autoroll-3404fe99-2bbe-4848-897c-e566560e5fe9-1689284040
Jul 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/743ad92f5de2..52613fcc0780 2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for GL/Ganesh. 2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for specifying a config via --config. 2023-07-13 johnstiles@google.com Fix swizzled compound assignment with lvalue side-effects in Metal. 2023-07-13 johnstiles@google.com Ensure index-substitution expressions are initialized before use. 2023-07-13 brianosman@google.com Remove SkOpts_skx.cpp completely 2023-07-13 ayzhao@google.com Fix some missing C++ standard library includes 2023-07-13 robertphillips@google.com Merge Ganesh and Graphite TiledTextureUtils::DrawImageRect implementations 2023-07-13 robertphillips@google.com Switch DrawImageRect_Ganesh to work at the SkCanvas level 2023-07-13 johnstiles@google.com Add unit test for lvalue side-effects in swizzled compound assignment. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Jul 13, 2023
skia-flutter-autoroll
force-pushed
the
skia-flutter-autoroll-3404fe99-2bbe-4848-897c-e566560e5fe9-1689284040
branch
from
July 13, 2023 21:34
981f089
to
811beca
Compare
fluttergithubbot
approved these changes
Jul 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 14, 2023
…130538) flutter/engine@0f0436b...8a42bfc 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 52613fcc0780 to 9e4f5cc3aeb4 (1 revision) (flutter/engine#43659) 2023-07-13 jonahwilliams@google.com [Impeller] no-op fragment program on Android until it works. (flutter/engine#43657) 2023-07-13 31859944+LongCatIsLooong@users.noreply.github.com Reland #43118 "Add a flag to ParagraphBuilder for rounding hack migration" (flutter/engine#43647) 2023-07-13 ychris@google.com Unmerge threads if the current merger is the only one that's merged. (flutter/engine#43652) 2023-07-13 dnfield@google.com Revert flutter/engine#43533 (flutter/engine#43654) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 743ad92f5de2 to 52613fcc0780 (9 revisions) (flutter/engine#43655) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
) https://skia.googlesource.com/skia.git/+log/743ad92f5de2..52613fcc0780 2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for GL/Ganesh. 2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for specifying a config via --config. 2023-07-13 johnstiles@google.com Fix swizzled compound assignment with lvalue side-effects in Metal. 2023-07-13 johnstiles@google.com Ensure index-substitution expressions are initialized before use. 2023-07-13 brianosman@google.com Remove SkOpts_skx.cpp completely 2023-07-13 ayzhao@google.com Fix some missing C++ standard library includes 2023-07-13 robertphillips@google.com Merge Ganesh and Graphite TiledTextureUtils::DrawImageRect implementations 2023-07-13 robertphillips@google.com Switch DrawImageRect_Ganesh to work at the SkCanvas level 2023-07-13 johnstiles@google.com Add unit test for lvalue side-effects in swizzled compound assignment. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
deleted the
skia-flutter-autoroll-3404fe99-2bbe-4848-897c-e566560e5fe9-1689284040
branch
July 20, 2023 22:07
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
) https://skia.googlesource.com/skia.git/+log/743ad92f5de2..52613fcc0780 2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for GL/Ganesh. 2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for specifying a config via --config. 2023-07-13 johnstiles@google.com Fix swizzled compound assignment with lvalue side-effects in Metal. 2023-07-13 johnstiles@google.com Ensure index-substitution expressions are initialized before use. 2023-07-13 brianosman@google.com Remove SkOpts_skx.cpp completely 2023-07-13 ayzhao@google.com Fix some missing C++ standard library includes 2023-07-13 robertphillips@google.com Merge Ganesh and Graphite TiledTextureUtils::DrawImageRect implementations 2023-07-13 robertphillips@google.com Switch DrawImageRect_Ganesh to work at the SkCanvas level 2023-07-13 johnstiles@google.com Add unit test for lvalue side-effects in swizzled compound assignment. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#130538) flutter/engine@0f0436b...8a42bfc 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 52613fcc0780 to 9e4f5cc3aeb4 (1 revision) (flutter/engine#43659) 2023-07-13 jonahwilliams@google.com [Impeller] no-op fragment program on Android until it works. (flutter/engine#43657) 2023-07-13 31859944+LongCatIsLooong@users.noreply.github.com Reland flutter#43118 "Add a flag to ParagraphBuilder for rounding hack migration" (flutter/engine#43647) 2023-07-13 ychris@google.com Unmerge threads if the current merger is the only one that's merged. (flutter/engine#43652) 2023-07-13 dnfield@google.com Revert flutter/engine#43533 (flutter/engine#43654) 2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 743ad92f5de2 to 52613fcc0780 (9 revisions) (flutter/engine#43655) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/743ad92f5de2..52613fcc0780
2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for GL/Ganesh.
2023-07-13 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Add support for specifying a config via --config.
2023-07-13 johnstiles@google.com Fix swizzled compound assignment with lvalue side-effects in Metal.
2023-07-13 johnstiles@google.com Ensure index-substitution expressions are initialized before use.
2023-07-13 brianosman@google.com Remove SkOpts_skx.cpp completely
2023-07-13 ayzhao@google.com Fix some missing C++ standard library includes
2023-07-13 robertphillips@google.com Merge Ganesh and Graphite TiledTextureUtils::DrawImageRect implementations
2023-07-13 robertphillips@google.com Switch DrawImageRect_Ganesh to work at the SkCanvas level
2023-07-13 johnstiles@google.com Add unit test for lvalue side-effects in swizzled compound assignment.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,kjlubick@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md