Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] [Impeller] Made the clear optimization handle backdrop filters. (#44192) #44222

Merged
merged 1 commit into from Aug 2, 2023
Merged

[CP] [Impeller] Made the clear optimization handle backdrop filters. (#44192) #44222

merged 1 commit into from Aug 2, 2023
+21 −1

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Aug 1, 2023 •
edited

cherry-pick of #44192

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@zanderso
Copy link
Member

zanderso commented Aug 1, 2023

For a CP to the beta branch, the target brach for this PR should be flutter-3.13-candidate.0

@gaaclarke gaaclarke mentioned this pull request Aug 1, 2023
Closed
@gaaclarke gaaclarke changed the base branch from flutter-3.13-candidate.15 to flutter-3.13-candidate.0 August 1, 2023 16:36
@gaaclarke gaaclarke force-pushed the cherry-b3df4d767c9d92d969032fead7ff992392832bd4 branch from 535da17 to 8170549 Compare August 1, 2023 16:38
@gaaclarke
Copy link
Member Author

For a CP to the beta branch, the target brach for this PR should be flutter-3.13-candidate.0

thanks, done

@gaaclarke gaaclarke changed the title [Impeller] Made the clear optimization handle backdrop filters. (#44192) [CP] [Impeller] Made the clear optimization handle backdrop filters. (#44192) Aug 1, 2023
@XilaiZhang
Copy link
Contributor

seems like tests are failing on this cherrypick request. we might drop this one for now.

cc @CaseyHillers @itsjustkevin

@gaaclarke
Copy link
Member Author

seems like tests are failing on this cherrypick request. we might drop this one for now.

cc @CaseyHillers @itsjustkevin

The failures in CI are actually infra failures and not related to the contents of the cherry-pick.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2023
@auto-submit auto-submit bot merged commit 7568412 into flutter:flutter-3.13-candidate.0 Aug 2, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
5 participants
@gaaclarke @zanderso @XilaiZhang @chinmaygarde @CaseyHillers