[web] ScreenOrientation singleton #45304
Conversation
mdebbar
added
the
autosubmit
Yep, I thought about that, then decided to keep the PR simple for now. |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/45304, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Goldens? You must be drunk flutter-dashboard! |
|
(@mdebbar there was a change wrt dithering a couple of weeks ago, not sure how old this branch is, but maybe it needs a rebase so the dithering algorithm doesn't cause golden changes?) |
|
Golden file changes are available for triage from new commit, Click here to view. |
mdebbar
added
the
autosubmit
…134956) flutter/engine@be7a039...e1c784e 2023-09-18 skia-flutter-autoroll@skia.org Roll Skia from f8065ca00d0c to 0c990ab9e097 (7 revisions) (flutter/engine#45979) 2023-09-18 mdebbar@google.com [web] ScreenOrientation singleton (flutter/engine#45304) 2023-09-18 mdebbar@google.com [web] De-singletonize MouseCursor for multi-view (flutter/engine#45295) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#134956) flutter/engine@be7a039...e1c784e 2023-09-18 skia-flutter-autoroll@skia.org Roll Skia from f8065ca00d0c to 0c990ab9e097 (7 revisions) (flutter/engine#45979) 2023-09-18 mdebbar@google.com [web] ScreenOrientation singleton (flutter/engine#45304) 2023-09-18 mdebbar@google.com [web] De-singletonize MouseCursor for multi-view (flutter/engine#45295) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Update tap_region.dart Update editable_text.dart
One more piece moving out of `FlutterViewEmbedder`. `ScreenOrientation` is a singleton class that can be used to control the screen orientation of the browser. Part of flutter/flutter#134443
One more piece moving out of
FlutterViewEmbedder.ScreenOrientationis a singleton class that can be used to control the screen orientation of the browser.Part of flutter/flutter#134443