Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a comment on clang_arm64_apilevel26 toolchain usage #45467

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Adds a comment on clang_arm64_apilevel26 toolchain usage #45467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions shell/platform/android/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,11 @@ action("android_jar") {

if (enable_vulkan_validation_layers) {
assert(impeller_enable_vulkan)

# We use a different toolchain here so that vulkan validation layers are
# built against API level 26, which they require, rather than the default.
# This is safe because the Engine can do a version check before loading the
# .so for the validation layers.
apilevel26_toolchain = "//build/toolchain/android:clang_arm64_apilevel26"
validation_layer_target =
"//third_party/vulkan_validation_layers($apilevel26_toolchain)"
Expand Down