Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace-to-file switch #45553

Merged
merged 2 commits into from Sep 12, 2023
Merged

Add trace-to-file switch #45553

merged 2 commits into from Sep 12, 2023

Conversation

derekxu16
Copy link
Contributor

No description provided.

@derekxu16
Copy link
Contributor Author

Do I need to update FlutterShellArgs.java and FlutterAcitivtyDelegate.java?

@derekxu16 derekxu16 marked this pull request as ready for review September 7, 2023 20:33
@christopherfujino christopherfujino removed their request for review September 7, 2023 20:36
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, as I've never seen these files before, I don't think I'm the best person to review. If you can wait a week, this should get picked up in Engine PR triage. Otherwise I would ask in the discord server #hackers-engine who the best reviewer would be.

@derekxu16 derekxu16 merged commit 9b940c0 into flutter:main Sep 12, 2023
25 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 12, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 12, 2023
…134553)

flutter/engine@8a8ddae...d4698c6

2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 7e9b94634911 to f3f0cab7efd0 (1 revision) (flutter/engine#45710)
2023-09-12 derekx@google.com Add trace-to-file switch (flutter/engine#45553)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants