Use safer GrDirectContext APIs #45644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianosman
approved these changes
Sep 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2023
8 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 11, 2023
…134439) flutter/engine@2b5961c...d593002 2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SFM4ele7RYnVMhr7S... to cUKimo52R-2EIfHh5... (flutter/engine#45647) 2023-09-11 kjlubick@users.noreply.github.com Use safer GrDirectContext APIs (flutter/engine#45644) 2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 787b61f00100 to 2fa311521fb2 (1 revision) (flutter/engine#45642) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from SFM4ele7RYnV to cUKimo52R-2E If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
added a commit
that referenced
this pull request
Sep 11, 2023
Follow-up to #45644 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
victorgalo
pushed a commit
to victorgalo/flutter
that referenced
this pull request
Sep 11, 2023
…lutter#134439) flutter/engine@2b5961c...d593002 2023-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SFM4ele7RYnVMhr7S... to cUKimo52R-2EIfHh5... (flutter/engine#45647) 2023-09-11 kjlubick@users.noreply.github.com Use safer GrDirectContext APIs (flutter/engine#45644) 2023-09-11 skia-flutter-autoroll@skia.org Roll Skia from 787b61f00100 to 2fa311521fb2 (1 revision) (flutter/engine#45642) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from SFM4ele7RYnV to cUKimo52R-2E If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In http://review.skia.org/750403 and http://review.skia.org/751523, Skia modified some
GrDirectContextAPIs to make them less error-prone in response to https://crbug.com/1475906. This updates Flutter to call those modified APIs.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.