Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios] upload extension safe artifacts #45664

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[ios] upload extension safe artifacts #45664

merged 2 commits into from
Sep 12, 2023

Conversation

cyanglaz
Copy link
Contributor

Uploads the artifacts for extension safe build. These artifacts need to be codesigned.

part of flutter/flutter#124291

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz marked this pull request as ready for review September 11, 2023 20:22
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Sep 11, 2023 •
edited

@godofredoc Looks like the CI has passed and the artifacts are uploaded successfully!
Could you please review the change :)

@godofredoc
Copy link
Contributor

@godofredoc Looks like the CI has passed and the artifacts are uploaded successfully! Could you please review the change :)

Did you have a chance to run this change with the framework presubmit?

godofredoc
godofredoc reviewed Sep 11, 2023
View reviewed changes
ci/builders/mac_ios_engine.json
{
"drone_dimensions": [
"device_type=none",
"mac_model=Macmini8,1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they have to run on x64 machines? if not I'd recommend to remove this line here and below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from other above jobs. I thought the jobs for arm64 builds can be run on arm machines, but the ones without arm64 (like this one) should not.
I can fix the existing ones in a separate PR then fix this too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move all the jobs to arm machines except the x86 simulator

@cyanglaz
Copy link
Contributor Author

Did you have a chance to run this change with the framework presubmit?

How do I do that?

@cyanglaz cyanglaz force-pushed the upload_extension_safe_artifacts branch from 1c98c88 to dcea548 Compare September 12, 2023 18:49
@cyanglaz
Copy link
Contributor Author

framework presubmit ci testing PR created: flutter/flutter#134582

@cyanglaz
Copy link
Contributor Author

@godofredoc framework presubmit passed except the mentioned ones in the doc and the one that is current already failing on ToT.
flutter/flutter#134582

godofredoc
godofredoc approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for validating the change end to end.

@cyanglaz
Copy link
Contributor Author

Thanks for validating the change end to end.

I never thought of validating the pre submit engines. It is a nice thing to add to my engine workflow to ensure the engine roll doesn't fail!

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot merged commit 4378fe3 into flutter:main Sep 12, 2023
29 checks passed
@cyanglaz cyanglaz deleted the upload_extension_safe_artifacts branch September 12, 2023 22:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
4378fe330 [ios] upload extension safe artifacts (flutter/engine#45664)
1e4c7e7
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
Roll Flutter Engine from c90fadf45d44 to 7c78ea210c19 (10 revisions) (#…
68ce499 
…134597)

flutter/engine@c90fadf...7c78ea2

2023-09-12 zanderso@users.noreply.github.com Revert "Lazily allocate RasterCacheItems only when caching is enabled" (flutter/engine#45734)
2023-09-12 1961493+harryterkelsen@users.noreply.github.com Revert "Use a single OffscreenCanvas for rendering in CanvasKit" (flutter/engine#45744)
2023-09-12 chinmaygarde@google.com [Impeller] Patch the compiler to account for subpass inputs and PSO metadata. (flutter/engine#45739)
2023-09-12 chinmaygarde@google.com [Impeller] Fix swapchain recreation for non-polling cases. (flutter/engine#45740)
2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QgAHx3BtJfN3TmodS... to UCa49z8fu0hD9cypj... (flutter/engine#45738)
2023-09-12 ychris@google.com [ios] upload extension safe artifacts (flutter/engine#45664)
2023-09-12 30870216+gaaclarke@users.noreply.github.com Added test to assert the vulkan embedder threadsafe vkqueue usage (flutter/engine#45732)
2023-09-12 chinmaygarde@google.com [Impeller] If validations are enabled but not found, still create the VK context. (flutter/engine#45674)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) (flutter/engine#45729)
2023-09-12 1961493+harryterkelsen@users.noreply.github.com Use a single OffscreenCanvas for rendering in CanvasKit (flutter/engine#42672)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from QgAHx3BtJfN3 to UCa49z8fu0hD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@cyanglaz cyanglaz mentioned this pull request Sep 13, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 18, 2023
[ios] use python script to generate extension safe frameworks and cod…
945a79c 
…e sign them (#45781)

Generates the fat framework for extension safe variants and add them to the code sign list.

Also reverts part of #45664 where the variants are uploaded in separate archive. Now with this change, the extension safe is inside a "extension_safe" folder under existing archive. 

fixes flutter/flutter#124291

The destination folder after this change:
- An extension_safe folder is added, which includes the extension safe Flutter.frameworks and dsym
- The artifacts.zip now includes the `extension_safe` except the dysm
- A extension_safe_Flutter.dsym.zip is created (under ios/release/) , which includes the extension_safe/Flutter.dsym

<img width="508" alt="Screenshot 2023-09-13 at 3 26 23 PM" src="https://github.com/flutter/engine/assets/3756895/84901ef1-af89-413f-94c7-74ed0aa36da6">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Flutter Engine from c90fadf45d44 to 7c78ea210c19 (10 revisions) (f…
e608579 
…lutter#134597)

flutter/engine@c90fadf...7c78ea2

2023-09-12 zanderso@users.noreply.github.com Revert "Lazily allocate RasterCacheItems only when caching is enabled" (flutter/engine#45734)
2023-09-12 1961493+harryterkelsen@users.noreply.github.com Revert "Use a single OffscreenCanvas for rendering in CanvasKit" (flutter/engine#45744)
2023-09-12 chinmaygarde@google.com [Impeller] Patch the compiler to account for subpass inputs and PSO metadata. (flutter/engine#45739)
2023-09-12 chinmaygarde@google.com [Impeller] Fix swapchain recreation for non-polling cases. (flutter/engine#45740)
2023-09-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from QgAHx3BtJfN3TmodS... to UCa49z8fu0hD9cypj... (flutter/engine#45738)
2023-09-12 ychris@google.com [ios] upload extension safe artifacts (flutter/engine#45664)
2023-09-12 30870216+gaaclarke@users.noreply.github.com Added test to assert the vulkan embedder threadsafe vkqueue usage (flutter/engine#45732)
2023-09-12 chinmaygarde@google.com [Impeller] If validations are enabled but not found, still create the VK context. (flutter/engine#45674)
2023-09-12 skia-flutter-autoroll@skia.org Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) (flutter/engine#45729)
2023-09-12 1961493+harryterkelsen@users.noreply.github.com Use a single OffscreenCanvas for rendering in CanvasKit (flutter/engine#42672)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from QgAHx3BtJfN3 to UCa49z8fu0hD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@harryterkelsen
[ios] use python script to generate extension safe frameworks and cod…
00e9b5e 
…e sign them (#45781)

Generates the fat framework for extension safe variants and add them to the code sign list.

Also reverts part of #45664 where the variants are uploaded in separate archive. Now with this change, the extension safe is inside a "extension_safe" folder under existing archive. 

fixes flutter/flutter#124291

The destination folder after this change:
- An extension_safe folder is added, which includes the extension safe Flutter.frameworks and dsym
- The artifacts.zip now includes the `extension_safe` except the dysm
- A extension_safe_Flutter.dsym.zip is created (under ios/release/) , which includes the extension_safe/Flutter.dsym

<img width="508" alt="Screenshot 2023-09-13 at 3 26 23 PM" src="https://github.com/flutter/engine/assets/3756895/84901ef1-af89-413f-94c7-74ed0aa36da6">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godofredoc godofredoc godofredoc approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
2 participants
@cyanglaz @godofredoc