Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename layoutGoals to kLayoutGoals to enforce lints on headers. #46054

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Rename layoutGoals to kLayoutGoals to enforce lints on headers. #46054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/platform/darwin/macos/framework/Source/FlutterKeyboardManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ - (void)buildLayout {

std::map<uint32_t, LayoutGoal> mandatoryGoalsByChar;
std::map<uint32_t, LayoutGoal> usLayoutGoalsByKeyCode;
for (const LayoutGoal& goal : flutter::layoutGoals) {
for (const LayoutGoal& goal : flutter::kLayoutGoals) {
if (goal.mandatory) {
mandatoryGoalsByChar[goal.keyChar] = goal;
} else {
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/darwin/macos/framework/Source/KeyCodeMap.g.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@
const uint64_t kCapsLockPhysicalKey = 0x00070039;
const uint64_t kCapsLockLogicalKey = 0x100000104;

const std::vector<LayoutGoal> layoutGoals = {
const std::vector<LayoutGoal> kLayoutGoals = {
LayoutGoal{0x31, 0x20, false}, // Space
LayoutGoal{0x27, 0x22, false}, // Quote
LayoutGoal{0x2b, 0x2c, false}, // Comma
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/darwin/macos/framework/Source/KeyCodeMap_Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,6 @@ typedef struct {
* All keys that Flutter wants to derive layout for, and guides on how to derive
* them.
*/
extern const std::vector<LayoutGoal> layoutGoals;
extern const std::vector<LayoutGoal> kLayoutGoals;

} // namespace flutter