Add missing headers to the fml source_set. #47232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These being missing came up when internal build rules were being derived from the ones here.
zanderso
approved these changes
Oct 23, 2023
chinmaygarde
added
the
autosubmit
|
I remember being surprised that this didn't come up in CI. I assumed we were using globs since everything was green. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2023
…137100) flutter/engine@e89f042...abeab89 2023-10-23 30870216+gaaclarke@users.noreply.github.com [Impeller] Added tests to assert empty saveLayer behaviors. (flutter/engine#47138) 2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from d534571c4bc3 to 73e9879f06e7 (1 revision) (flutter/engine#47233) 2023-10-23 chinmaygarde@google.com Add missing headers to the fml source_set. (flutter/engine#47232) 2023-10-23 jonahwilliams@google.com [Impeller] Vk query cleanups. (flutter/engine#47208) 2023-10-23 skia-flutter-autoroll@skia.org Roll Skia from 4976279e4441 to d534571c4bc3 (1 revision) (flutter/engine#47231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
These being missing came up when internal build rules were being derived from the ones here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These being missing came up when internal build rules were being derived from the ones here.